Page MenuHomePhabricator

Replace ApiResult::setRawMode use in EntityDataSerializationService
Closed, ResolvedPublic

Description

We need to get rid of it as part of the APIResult rewrite.

Event Timeline

Lydia_Pintscher raised the priority of this task from to High.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added subscribers: aude, JanZerebecki, daniel and 2 others.

You've also got calls to getIsRawMode() in ResultBuilder and GetEntities, and some calls to setRawMode() in some unit tests.

This issue is blocking 7 commits in mediawiki core (the blocked issue noted here is blocking others), so it would help us if it could make it into the next sprint.

I'll put it on the list for the sprint start meeting on Tuesday.

Despite T93353 being closed, I still see calls to getIsRawMode() in ResultBuilder and GetEntities, and to setRawMode() in some tests.

@Anomie thanks for noticing that. I suggest we make a new task for those.

created T95168 for getIsRawMode and getIsRawMode

For everyone's info I have just started looking at all of this

Change 223794 had a related patch set uploaded (by Addshore):
Move ApiResult::getIsRawMode call to ApiHelperFactory

https://gerrit.wikimedia.org/r/223794

Change 225036 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Drop some unused code from ResultBuilder and related

https://gerrit.wikimedia.org/r/225036

Change 223794 merged by jenkins-bot:
Move ApiResult::getIsRawMode call to ApiHelperFactory

https://gerrit.wikimedia.org/r/223794

Addshore claimed this task.

Change 225036 merged by jenkins-bot:
Drop some unused code from ResultBuilder and related

https://gerrit.wikimedia.org/r/225036

Restricted Application added a project: User-Addshore. · View Herald TranscriptOct 16 2020, 5:41 PM