Page MenuHomePhabricator
Create Task
Maniphest T92970

Replace ApiResult::setRawMode use in EntityDataSerializationService
Closed, ResolvedPublic
Actions

Description

We need to get rid of it as part of the APIResult rewrite.

Details

SubjectRepoBranchLines +/-
Drop some unused code from ResultBuilder and relatedmediawiki/extensions/Wikibasemaster+61 -62
Move ApiResult::getIsRawMode call to ApiHelperFactorymediawiki/extensions/Wikibasemaster+36 -25
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lydia_Pintscher created this task.Mar 17 2015, 3:48 PM
Lydia_Pintscher raised the priority of this task from to High.
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher added projects: MediaWiki-Action-API, Wikidata.
Lydia_Pintscher added subscribers: aude, JanZerebecki, daniel and 2 others.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2015, 3:48 PM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 17 2015, 3:49 PM
Anomie added a comment.Mar 17 2015, 6:24 PM

You've also got calls to getIsRawMode() in ResultBuilder and GetEntities, and some calls to setRawMode() in some unit tests.

Anomie moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Mar 17 2015, 8:18 PM
• ksmith subscribed.EditedMar 20 2015, 7:48 PM

This issue is blocking 7 commits in mediawiki core (the blocked issue noted here is blocking others), so it would help us if it could make it into the next sprint.

hoo added a project: MediaWiki-extensions-WikibaseRepository.Mar 20 2015, 7:58 PM
hoo set Security to None.
Lydia_Pintscher added a comment.Mar 21 2015, 7:43 AM

I'll put it on the list for the sprint start meeting on Tuesday.

Tobi_WMDE_SW added a subtask: T93353: Drop support for API style XML output from Special:EntityData.Mar 24 2015, 2:26 PM
Tobi_WMDE_SW subscribed.

Resolving T93353 will fix this.

hoo closed subtask T93353: Drop support for API style XML output from Special:EntityData as Resolved.Apr 5 2015, 1:25 AM
Anomie added a comment.Apr 6 2015, 2:27 PM

Despite T93353 being closed, I still see calls to getIsRawMode() in ResultBuilder and GetEntities, and to setRawMode() in some tests.

aude added a comment.Apr 6 2015, 2:31 PM

@Anomie thanks for noticing that. I suggest we make a new task for those.

aude added a comment.Apr 6 2015, 2:33 PM

created T95168 for getIsRawMode and getIsRawMode

Anomie added a parent task: T96596: Add wfDeprecated() to deprecated ApiResult methods.Apr 20 2015, 6:37 PM
aude added a parent task: T78652: DataModelSerialization: Serializers to be used with the MediaWiki API need to inject meta-info like _indexTagNames, to allow XML output from API modules..May 12 2015, 1:35 PM
Addshore subscribed.Jul 9 2015, 2:41 PM

For everyone's info I have just started looking at all of this

gerritbot subscribed.Jul 15 2015, 11:43 AM

Change 223794 had a related patch set uploaded (by Addshore):
Move ApiResult::getIsRawMode call to ApiHelperFactory

https://gerrit.wikimedia.org/r/223794

gerritbot added a project: Patch-For-Review.Jul 15 2015, 11:43 AM
gerritbot added a comment.Jul 16 2015, 12:40 PM

Change 225036 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Drop some unused code from ResultBuilder and related

https://gerrit.wikimedia.org/r/225036

gerritbot added a comment.Jul 16 2015, 5:02 PM

Change 223794 merged by jenkins-bot:
Move ApiResult::getIsRawMode call to ApiHelperFactory

https://gerrit.wikimedia.org/r/223794

Addshore mentioned this in rEWBA594f5c5af494: Move ApiResult::getIsRawMode call to ApiHelperFactory.Jul 16 2015, 5:02 PM
Diffusion mentioned this in rMEXT49cf6ed951ea: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Jul 16 2015, 5:02 PM
• ksmith unsubscribed.Jul 18 2015, 1:02 AM
Addshore closed this task as Resolved.Jul 23 2015, 11:56 AM
Addshore claimed this task.
gerritbot added a comment.Aug 12 2015, 10:14 AM

Change 225036 merged by jenkins-bot:
Drop some unused code from ResultBuilder and related

https://gerrit.wikimedia.org/r/225036

thiemowmde mentioned this in rMEXT80fa2f21865a: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 12 2015, 10:14 AM
Addshore mentioned this in rEWBA75b51a445c15: Drop some unused code from ResultBuilder and related.Aug 12 2015, 10:14 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:41 PM
Restricted Application added a project: User-Addshore. · View Herald TranscriptOct 16 2020, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL