Page MenuHomePhabricator
Create Task
Maniphest T93029

Null edit results in JS error, hung editor on mobile (stable)
Closed, ResolvedPublic
Actions

Description

If you make a null edit on English Wikipedia in stable mode, it throws a JS Error: "No changes to save". The browser then becomes hung on the saving screen. Null edits should be allowed on mobile, just as they are on desktop.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Allow null edits on mobile (same as desktop)mediawiki/extensions/MobileFrontendmaster+29 -13
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.Mar 18 2015, 12:08 AM
kaldari raised the priority of this task from to Needs Triage.
kaldari updated the task description. (Show Details)
kaldari added a project: Web-Team-Backlog-Archived.
kaldari subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2015, 12:08 AM
kaldari updated the task description. (Show Details)Mar 18 2015, 12:24 AM
kaldari set Security to None.
gerritbot subscribed.Mar 18 2015, 12:25 AM

Change 197446 had a related patch set uploaded (by Kaldari):
Allow null edits on mobile (same as desktop)

https://gerrit.wikimedia.org/r/197446

gerritbot added a project: Patch-For-Review.Mar 18 2015, 12:25 AM
Florian subscribed.Mar 18 2015, 6:32 AM
• KLans_WMF moved this task from Incoming to Product Owner Backlog on the Web-Team-Backlog-Archived board.Mar 18 2015, 5:13 PM
gerritbot added a comment.Mar 19 2015, 1:03 AM

Change 197446 merged by jenkins-bot:
Allow null edits on mobile (same as desktop)

https://gerrit.wikimedia.org/r/197446

Florian closed this task as Resolved.Mar 19 2015, 5:27 AM
Florian claimed this task.
Florian removed a project: Patch-For-Review.
kaldari mentioned this in rEMFRd3bb04f82506: Allow null edits on mobile (same as desktop).Mar 23 2015, 3:53 PM
Diffusion mentioned this in rMEXT9fb50d5f3a1f: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 23 2015, 3:55 PM
• Phabricator_maintenance moved this task from Product Owner Backlog to 2014-15 Q3 on the Web-Team-Backlog-Archived board.Mar 7 2018, 1:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits