Page MenuHomePhabricator

GitHub access l10n files needs to follow submodule directs, otherwise you'll get an error (e.g. with VisualEditor)
Closed, InvalidPublic

Description

Exception encountered, of type "Exception"
[0e595bfe] [no req]   Exception from line 25 of /vagrant/mediawiki/extensions/LocalisationUpdate/fetcher/GitHubFetcher.php: 
  Unable to get directory listing for wikimedia/mediawiki-extensions-VisualEditor
Backtrace:
#0 /vagrant/mediawiki/extensions/LocalisationUpdate/Updater.php(115): LU_GitHubF
etcher->fetchDirectory(string)
#1 /vagrant/mediawiki/extensions/LocalisationUpdate/Updater.php(137): LU_Updater
->fetchFiles(LU_FetcherFactory, string)
#2 /vagrant/mediawiki/extensions/LocalisationUpdate/update.php(65): LU_Updater->
execute(LU_Finder, LU_ReaderFactory, LU_FetcherFactory, array)
#3 /vagrant/mediawiki/maintenance/doMaintenance.php(103): LU->execute()
#4 /vagrant/mediawiki/extensions/LocalisationUpdate/update.php(83): require_once
(string)
#5 /var/www/w/MWScript.php(89): require_once(string)
#6 {main}

The URL that is fetched is https://api.github.com/repos/wikimedia/mediawiki-extensions-VisualEditor/contents/lib/ve/i18n which matches the on disk layout of a clone of the repository, but lib/ve is a submodule. The correct URL to get l10n files via GitHub's api is https://api.github.com/repos/wikimedia/VisualEditor/contents/i18n.

Event Timeline

bd808 raised the priority of this task from to Needs Triage.
bd808 updated the task description. (Show Details)
bd808 added subscribers: bd808, Nikerabbit.

As a first step we can catch the exception so that processing does not stop.

As per how to fix this... I am not really sure how would we know to use the different path without hard coding an exception for VE.

Jdforrester-WMF renamed this task from GitHub access to VisualEditor l10n files uses incorrect path to fetch submodule contents to GitHub access l10n files needs to follow submodule directs, otherwise you'll get an error (e.g. with VisualEditor).Mar 6 2017, 6:51 PM
Jdforrester-WMF removed a project: VisualEditor.

First time I've seen this; re-worded to make clear where the issue is.

The LocalisationUpdate extensions has been archived. See T309694 for details.