http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences lacks full styling for tabs most of the time I visit that page. I haven't been able to figure out a pattern, but it's annoying. There are no errors in developer console nor any failed http requests.
- Mentioned In
- rEGAT5c969bca3015: Fix overriding of vector styles in resources definition
rEGATb8ac385161c0: Fix overriding of vector styles in resources definition
rEGAT9088ae67edf8: Fix overriding of vector styles in resources definition
rMEXT2e4fb2d5c693: Updated mediawiki/extensions Project: mediawiki/extensions/Gather…
- Mentioned Here
- T94518: Watchlist notification bubble changed appearance on enwiki
T94699: Styling in the entity suggester has large fonts and other things not quite right on beta
T94808: mediawiki.special.preferences style sheet is missing on the Preferences page
These tab styles are provided by mediawiki.special.preferences.less from the Vector skin, added to the mediawiki.special.preferences core module (which doesn't have these tab styles).
It looks like these extra skin styles are not being loaded somehow.
The one for en.wikipedia.org only serves MediaWiki core's mediawiki.special.preferences.css. The one for mediawiki.org does contain Vector's additional styles.
(thus, might be useful to know that this was a problem before deployment yesterday)
and see also T94699 which I am pretty sure is related and likely the same cause.
04:45 < aude> https://github.com/wikimedia/mediawiki/blob/5fde727a92c0ed539c5ba927642f9cb564c5d4ec/resources/lib/jquery.ui/themes/smoothness/jquery.ui.theme.css
04:45 < aude> is being loaded
04:45 < aude> instead of https://github.com/wikimedia/mediawiki-skins-Vector/blob/a16d29f8a88e1a0a9d0ad704f251dcf4e3ed473c/skinStyles/jquery.ui/jquery.ui.theme.css
04:46 < aude> that's on beta wikidata
Ugh, you're not supposed to use $wgResourceModuleSkinStyles in extensions… it's for skins. I'm not sure if the proposed patch will even work, adding $wgGatherMobileSpecialPageResourceBoilerplate will probably continue to mess stuff up. You should have your own RL module with styles, and use the skinStyles option to define styles for Vector only.
Well, stuff breaks when you clobber globals, news at eleven. It's a chicken-and-egg problem: if we use a hook, someone could clobber $wgHooks. We must have some faith in developers :) Instead I documented it better: https://www.mediawiki.org/w/index.php?title=Manual:$wgResourceModuleSkinStyles&diff=1511052&oldid=1415414