| Nikerabbit | |
| Mar 18 2015, 9:13 AM |
| F108079: Screen_Shot_2015-04-02_at_10.02.00.png | |
| Apr 2 2015, 8:26 AM |
http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences lacks full styling for tabs most of the time I visit that page. I haven't been able to figure out a pattern, but it's annoying. There are no errors in developer console nor any failed http requests.
This feels like it might possibly be caused by the recent ResourceLoader change by @ori to resequence module loading? Random guess, but it's the only thing I know of that's changed lately.
These tab styles are provided by mediawiki.special.preferences.less from the Vector skin, added to the mediawiki.special.preferences core module (which doesn't have these tab styles).
It looks like these extra skin styles are not being loaded somehow.
http://bits.wikimedia.org/en.wikipedia.org/load.php?lang=en&modules=mediawiki.special.preferences&only=styles&skin=vector
http://bits.beta.wmflabs.org/en.wikipedia.beta.wmflabs.org/load.php?lang=en&modules=mediawiki.special.preferences&only=styles&skin=vector
Compare to e.g.
http://bits.wikimedia.org/www.mediawiki.org/load.php?lang=en&modules=mediawiki.special.preferences&only=styles&skin=vector
The one for en.wikipedia.org only serves MediaWiki core's mediawiki.special.preferences.css. The one for mediawiki.org does contain Vector's additional styles.
This has now hit production. https://en.wikipedia.org/wiki/Special:Preferences.
It seems de.wikipedia.org and www.wikidata.org are not affected, however. See my previous reply for the exact observation. I haven't found a cause yet.
and see also T94699 which I am pretty sure is related and likely the same cause.
04:45 < aude> https://github.com/wikimedia/mediawiki/blob/5fde727a92c0ed539c5ba927642f9cb564c5d4ec/resources/lib/jquery.ui/themes/smoothness/jquery.ui.theme.css
04:45 < aude> is being loaded
04:45 < aude> instead of https://github.com/wikimedia/mediawiki-skins-Vector/blob/a16d29f8a88e1a0a9d0ad704f251dcf4e3ed473c/skinStyles/jquery.ui/jquery.ui.theme.css
04:46 < aude> that's on beta wikidata
Change 201501 had a related patch set uploaded (by Aude):
Fix overriding of vector styles in resources definition
I've put this on the swat deploy calendar: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=151887&oldid=151884
Will get this merged asap
Ugh, you're not supposed to use $wgResourceModuleSkinStyles in extensions… it's for skins. I'm not sure if the proposed patch will even work, adding $wgGatherMobileSpecialPageResourceBoilerplate will probably continue to mess stuff up. You should have your own RL module with styles, and use the skinStyles option to define styles for Vector only.
Yay hooks and globals! ;-)
Sounds like another task to prevent extensions manipulating this erroneously... note MobileFrontend also uses this global.
MobileFrontend is probably within its rights to do it, since it has the Minerva skin inside. If it's using $wgResourceModuleSkinStyles['minerva'] only, it's good.
... yeh but we should at least have some kind of wrapper for this. I'm guessing a hook would be better than a global since this can apparently do catastrophic things?
Well, stuff breaks when you clobber globals, news at eleven. It's a chicken-and-egg problem: if we use a hook, someone could clobber $wgHooks. We must have some faith in developers :) Instead I documented it better: https://www.mediawiki.org/w/index.php?title=Manual:$wgResourceModuleSkinStyles&diff=1511052&oldid=1415414
Change 201503 had a related patch set uploaded (by Jdlrobson):
Fix overriding of vector styles in resources definition
Change 201501 merged by jenkins-bot:
Fix overriding of vector styles in resources definition
Change 201581 had a related patch set uploaded (by Jdlrobson):
Fix overriding of vector styles in resources definition
Change 201503 merged by jenkins-bot:
Fix overriding of vector styles in resources definition
Change 201581 merged by jenkins-bot:
Fix overriding of vector styles in resources definition