WikiEditor test throws "[Edit] Missing property editingSessionId"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Mar 18 2015, 7:01 PM

Project Tags

Referenced Files

None

Subscribers

Description

When WikiEditor is installed, the unit tests show this exception in the console. This is because code is insufficiently separated and both providing APIs and running code intended for the EditPage, selecting elements that don't exist and ending up unconditionally emitting events on page load (regardless of wgAction).

[Edit] Missing property "editingSessionId"
(anonymous function) @ ext.eventLogging.core.js:277
(anonymous function)
mw.track
mw.eventLog.prepare @ ext.eventLogging.core.js:192
mw.eventLog.logEvent @ ext.eventLogging.core.js:258
..
(anonymous function) @ load.php?modules=schema.Edit

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Only do client-side instrumentation on action=edit/action=submit	mediawiki/extensions/WikiEditor	wmf/1.25wmf22	+22 -20
Only do client-side instrumentation on action=edit/action=submit	mediawiki/extensions/WikiEditor	master	+22 -20
Only do client-side instrumentation on action=edit/action=submit	mediawiki/extensions/WikiEditor	wmf/1.25wmf21	+22 -20

Customize query in gerrit

Related Objects

Mentioned In: rMEXTf9644b264dde: Updated mediawiki/extensions Project: mediawiki/extensions/WikiEditor…
rEWED27766b30b81d: Only do client-side instrumentation on action=edit/action=submit
rEWED4d54fa447146: Only do client-side instrumentation on action=edit/action=submit
rEWED00b8d1e9eb43: Only do client-side instrumentation on action=edit/action=submit

Event Timeline

Krinkle created this task.Mar 18 2015, 7:01 PM

Krinkle raised the priority of this task from to Needs Triage.

Krinkle updated the task description. (Show Details)

Krinkle added projects: Regression, WikiEditor (2010).

Krinkle subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2015, 7:01 PM

Krinkle set Security to None.Mar 18 2015, 7:02 PM

Krinkle added subscribers: Krenair, Catrope.

Change 197810 had a related patch set uploaded (by Alex Monk):
Only do client-side instrumentation on action=edit/action=submit

https://gerrit.wikimedia.org/r/197810

gerritbot added a project: Patch-For-Review.Mar 19 2015, 12:00 AM

Aklapper triaged this task as Medium priority.Mar 19 2015, 12:24 PM

Change 197810 merged by jenkins-bot:
Only do client-side instrumentation on action=edit/action=submit

https://gerrit.wikimedia.org/r/197810

Change 198103 had a related patch set uploaded (by Alex Monk):
Only do client-side instrumentation on action=edit/action=submit

https://gerrit.wikimedia.org/r/198103

Change 198103 merged by jenkins-bot:
Only do client-side instrumentation on action=edit/action=submit

https://gerrit.wikimedia.org/r/198103

Change 198120 had a related patch set uploaded (by Alex Monk):
Only do client-side instrumentation on action=edit/action=submit

https://gerrit.wikimedia.org/r/198120

Change 198120 merged by jenkins-bot:
Only do client-side instrumentation on action=edit/action=submit

https://gerrit.wikimedia.org/r/198120

Should be better now.

Krenair removed a project: Patch-For-Review.Mar 19 2015, 10:37 PM

GOIII subscribed.Mar 20 2015, 11:51 AM

Krenair mentioned this in rEWED4d54fa447146: Only do client-side instrumentation on action=edit/action=submit.Mar 23 2015, 3:52 PM

Krenair mentioned this in rEWED00b8d1e9eb43: Only do client-side instrumentation on action=edit/action=submit.

Krenair mentioned this in rEWED27766b30b81d: Only do client-side instrumentation on action=edit/action=submit.

Diffusion mentioned this in rMEXTf9644b264dde: Updated mediawiki/extensions Project: mediawiki/extensions/WikiEditor….Mar 23 2015, 3:55 PM

GOIII moved this task from Backlog to Closed on the WikiEditor (2010) board.Apr 3 2016, 9:09 AM

WikiEditor test throws "[Edit] Missing property editingSessionId"Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

WikiEditor test throws "[Edit] Missing property editingSessionId"
Closed, ResolvedPublic
Actions