Page MenuHomePhabricator

Reference serialization could explode if user deletes reflist
Open, Stalled, NormalPublic8 Story Points

Description

If the user deletes the reflist, data-mw.id will refer to a nonexistent ID in the deleted reflist. This is fine in practice because of selser, but we probably shouldn't be doing this.

Event Timeline

Catrope created this task.Mar 19 2015, 12:22 AM
Catrope updated the task description. (Show Details)
Catrope raised the priority of this task from to Needs Triage.
Catrope added a subscriber: Catrope.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2015, 12:22 AM
Jdforrester-WMF triaged this task as Normal priority.Sep 1 2015, 7:27 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Is this actually an issue?

Jdforrester-WMF changed the task status from Open to Stalled.Sep 1 2015, 7:28 PM

I'm not sure if it's ever caused an issue in practice, but it's certainly worrying, since it only works by accident. I imagine this might cause problems if the reflist is deleted and a reference that reuses content from inside the reference is moved in the same edit, but I didn't try very hard to break it at the time. I saw cases where we sent HTML that didn't make any sense and selser magically saved the day, but that's not something I'd like to rely on.

Jdforrester-WMF edited a custom field.