Page MenuHomePhabricator

puppet lint check for resource names
Closed, InvalidPublic

Description

spawned from https://gerrit.wikimedia.org/r/#/c/197352/ where puppet lint check didn't warn about whitespace in resource name, however it sounds like we want resource names checked for allowed characters (either strictly or not)

Event Timeline

fgiunchedi raised the priority of this task from to Needs Triage.
fgiunchedi updated the task description. (Show Details)
fgiunchedi added projects: acl*sre-team, Puppet.
fgiunchedi subscribed.

@fgiunchedi I'm tempted to close this as invalid as i don't see any issue with having spaces in resource titles and in some cases (e.g. notify, exec) it can be desirable. cc @jhathaway in case they are aware of any issues.

Totally fair to mark invalid (done) @jbond, tbh I don't remember what the issue was!

Yeah I agree we should allow those, as you mention they are sometimes useful:

exec { '/usr/bin/cat /etc/os-release': logoutput => true }
notify { "Fact ${facts['fqdn']}": }