Page MenuHomePhabricator

SkinMinerva should makes it own decisions about rendering the main menu
Closed, DuplicatePublic

Description

Since the hook approach interferes with main menu event logging we should build the menu similar to how we add the nearby link if and only if available.

https://gerrit.wikimedia.org/r/197998 does this for Gather
A separate patch would be needed for Wikigrok

This way Gather and other extensions do not need to know anything about how MobileFrontend works and the main menu does not have to become a dumping ground.

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task to In Analysis on the Gather Sprint Diplodocus board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2015, 7:58 PM

Change 197998 had a related patch set uploaded (by Jdlrobson):
Delegate main menu generation to MobileFrontend generalise EL

https://gerrit.wikimedia.org/r/197998

Jdlrobson moved this task from Needs triage to Product triage on the Gather board.Mar 23 2015, 5:43 PM
Jdlrobson moved this task from Product triage to Developer backlog on the Gather board.

Change 199159 had a related patch set uploaded (by Robmoen):
Kill onPersonalTools hook as this is being removed on MF

https://gerrit.wikimedia.org/r/199159

Max and I don't really agree with the approach here. Let's figure out a better solution for the future.

Jdlrobson set Security to None.

Change 197998 abandoned by Jdlrobson:
Delegate main menu generation to MobileFrontend

Reason:
To be resolved at another time...

https://gerrit.wikimedia.org/r/197998

Change 199159 abandoned by Jdlrobson:
Kill onPersonalTools hook as this is being removed on MF

Reason:
Resolve later. Seems we have to convince all MF 2ers - mobile-l discussion for a later time.

https://gerrit.wikimedia.org/r/199159