[Regression wmf22] Link removal doesn't work on first click anymore
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Reproduced on mediawiki.org (1.25wmf22), but not on dewiki (1.25wmf21).

Steps to reproduce:

Open a page with links in VisualEditor (e.g. https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP?veaction=edit)
Click on one link
Click "Edit"
Click "Remove"

Expected: The link should be removed from the text

Observed: The link is still there, you need to click "Edit" and "Remove" again, to really remove the link (if you select another text and the link again, you need to click remove again twice).

Originally reported on: https://www.mediawiki.org/w/index.php?title=Topic:Sdvpq117bq8gwi66

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Associate the fragment in AnnotationInspector	VisualEditor/VisualEditor	wmf/1.25wmf22	+8 -2
	Associate the fragment in AnnotationInspector	VisualEditor/VisualEditor	master	+8 -2

Customize query in gerrit

Related Objects

Mentioned In: rGVEDc0a3e0de7a68: Associate the fragment in AnnotationInspector
rGVED9f435e49fad6: Associate the fragment in AnnotationInspector
T93163: Deleting links created via '[[' sequence has to be done twice to take effect

Event Timeline

Florian created this task.Mar 20 2015, 2:47 PM

Florian raised the priority of this task from to High.

Florian updated the task description. (Show Details)

Florian added a project: VisualEditor.

Florian subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2015, 2:47 PM

Romain_media subscribed.Mar 20 2015, 3:07 PM

Jdforrester-WMF renamed this task from Link removal doesn't work on first click anymore to [Regression wmf22] Link removal doesn't work on first click anymore.Mar 20 2015, 5:28 PM

Jdforrester-WMF set Security to None.

Change 198428 had a related patch set uploaded (by Mooeypoo):
Use the correct fragment for annotation selections

https://gerrit.wikimedia.org/r/198428

gerritbot added a project: Patch-For-Review.Mar 20 2015, 11:21 PM

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.Mar 20 2015, 11:30 PM

• matmarex mentioned this in T93163: Deleting links created via '[[' sequence has to be done twice to take effect.Mar 20 2015, 11:35 PM

Jdforrester-WMF assigned this task to Mooeypoo.Mar 20 2015, 11:36 PM

Jdforrester-WMF merged a task: T93163: Deleting links created via '[[' sequence has to be done twice to take effect.

Jdforrester-WMF added a project: VisualEditor-EditingTools.

Jdforrester-WMF added subscribers: Jdforrester-WMF, • matmarex, Krenair.

Change 198445 had a related patch set uploaded (by Jforrester):
Associate the fragment in AnnotationInspector

https://gerrit.wikimedia.org/r/198445