Page MenuHomePhabricator

Investigate & fix/suppress negative dsr warnings seen in production
Closed, ResolvedPublic

Description

There are lots of pages that emit 'negative dsr' warnings. Worth investigating and fixing or suppressing errors that are about known inconsistencies that get resolved as part of the dsr computation algorithm.

Event Timeline

ssastry raised the priority of this task from to Medium.
ssastry updated the task description. (Show Details)
ssastry added a project: Parsoid.
ssastry subscribed.

Change 199164 had a related patch set uploaded (by Subramanya Sastry):
T93369: Propagate null values without updating them

https://gerrit.wikimedia.org/r/199164

Change 199164 merged by jenkins-bot:
T93369: Nulls in DSR computation should not be coerced to 0

https://gerrit.wikimedia.org/r/199164

ssastry removed a project: Patch-For-Review.

We had a HUGE reduction in warnings from that one fix.

But, we still have a few left. Try: http://localhost:8000/fawiki/%D8%A7%D8%B3%E2%80%8C%D8%A7%D9%85_%DB%8C%D9%88-%DB%B1%DB%B3%DB%B7?oldid=11515858

Looking at parsoid output and php parser output https://fa.wikipedia.org/wiki/%D8%A7%D8%B3%E2%80%8C%D8%A7%D9%85_%DB%8C%D9%88-%DB%B1%DB%B3%DB%B7?oldid=11515858 it looks like bad wikitext leading to fostered content which is probably screwing up dsr computation. But, worth investigating to see if we can tweak the DSR algo in some fashion to handle that. But, low priority.

ssastry claimed this task.

We have fixed a bunch of these over the years. We can do another round of investigation later and file more specific bugs vs. this catch-all generic bug.