Page MenuHomePhabricator

Posting a reply to a message makes the new message to not appear, and JavaScript error is thrown: "threadWrapper is undefined "
Open, LowestPublic

Description

On mediawiki.org, since this week, posting any reply to a LiquidThread message causes the message to disappear, although the message is posted.

Steps to reproduce:

  1. Go to https://www.mediawiki.org/wiki/LiquidThreads_Test_Page
  2. Reply to a message. Write a comment and hit the save button

Expected results:

  • The message is added to the current thread, hiding the edit area

Actual results:

  • The edit area disappears, and the message is not added to the current thread, although the message has been saved. Reloading the page displays the message.
  • The error console displays an error:
		// Update reply links
		var threadWrapper = $( threadContainer ).closest( '.lqt_thread' )[0];
		var threadId = threadWrapper.id.substring( prefixLength );
                               ^

TypeError: threadWrapper is undefined lqt.js:630:6

Event Timeline

Ciencia_Al_Poder updated the task description. (Show Details)
Ciencia_Al_Poder raised the priority of this task from to Needs Triage.
Ciencia_Al_Poder added a subscriber: Ciencia_Al_Poder.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2015, 4:33 PM

The problem isn't JavaScript...

I'm debugging it and the AJAX response returns the generated HTML that will be injected to the page, but it doesn't contain the new reply.

Looks like it's getting stale records. Presumably, it's querying the SLAVE server where replication hasn't caught up the new reply.

I don't see recent changes in rELQT repo that might be causing this. If LQT is fetching results from slave servers in this case and this hasn't changed, then it isn't a regression, but still I don't know why it wasn't happening before

Aklapper renamed this task from Posting a reply to a message makes the new message to not appear, and a JavaScript error is thrown to Posting a reply to a message makes the new message to not appear, and JavaScript error is thrown: "threadWrapper is undefined ".Mar 23 2015, 8:52 PM
Aklapper triaged this task as Normal priority.
He7d3r added a subscriber: He7d3r.Mar 28 2015, 9:09 PM
He7d3r updated the task description. (Show Details)Mar 28 2015, 9:12 PM
He7d3r added projects: Regression, JavaScript.
Florian reopened this task as Open.Dec 2 2015, 10:43 PM
Florian added a subscriber: Paladox.

@Paladox We usually merge newer tasks into older ones, not the other way.

Jdforrester-WMF lowered the priority of this task from Normal to Lowest.Aug 4 2016, 11:33 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

LiquidThreads has been replaced by StructuredDiscussions on all Wikimedia production wikis (except one, which will be done soon). It is no longer under active development or maintenance, so I'm re-classifying all open LQT tasks as "Lowest" priority.