Page MenuHomePhabricator
Create Task
Maniphest T93436

TemplateParser spewing eval() errors
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Spotted endlessly in production:

390 Invalid argument: function: not string, closure, or array in /srv/mediawiki/php-1.25wmf21/includes/TemplateParser.php on line 203
202 error: syntax error, unexpected T_STRING in /srv/mediawiki/php-1.25wmf21/includes/TemplateParser.php(136) : eval()'d code on line 1

Two bugs here:

  1. The broken template causing parse errors needs fixing ASAP
  2. We need a way to keep broken templates from hitting prod

It was suggested on IRC earlier this week that we could help avoid this happening by adding a unit test to test template compilation prior to committing. The other option would be catching the error condition and failing more gracefully.

Details

ProjectBranchLines +/-Subject
mediawiki/corewmf/1.25wmf21+56 -6TemplateParser: Don't fatal on cache misses
mediawiki/corewmf/1.25wmf22+56 -6TemplateParser: Don't fatal on cache misses
mediawiki/coremaster+56 -6TemplateParser: Don't fatal on cache misses
mediawiki/coremaster+4 -1Strip '?>' from lightncandy generated PHP code in TemplateParser
Customize query in gerrit

Related Objects

Event Timeline

demon created this task.Mar 20 2015, 9:50 PM
demon raised the priority of this task from to High.
demon updated the task description. (Show Details)
demon added projects: MediaWiki-General, Wikimedia-production-error.
demon added a subscriber: demon.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2015, 9:50 PM
Krenair added a subscriber: Krenair.Mar 20 2015, 9:54 PM
Krenair assigned this task to kaldari.Mar 20 2015, 11:43 PM
Krenair edited projects, added Readers-Web-Backlog; removed MediaWiki-General.
Krenair set Security to None.
kaldari added a comment.Mar 20 2015, 11:45 PM

Haven't been able to reproduce locally yet.

Relate bug: https://phabricator.wikimedia.org/T93445

gerritbot added a subscriber: gerritbot.Mar 21 2015, 12:30 AM

Change 198443 had a related patch set uploaded (by Kaldari):
Strip '?>' from lightncandy generated PHP code in TemplateParser

https://gerrit.wikimedia.org/r/198443

gerritbot added a project: Patch-For-Review.Mar 21 2015, 12:30 AM
kaldari added a comment.Mar 21 2015, 12:31 AM

Looks like it's because Zend doesn't care about the closing PHP tag, but I guess HHVM does.

Krenair added a project: HHVM.Mar 21 2015, 12:32 AM
gerritbot added a comment.Mar 21 2015, 12:45 AM

Change 198443 abandoned by Kaldari:
Strip '?>' from lightncandy generated PHP code in TemplateParser

Reason:
Doesn't fix bug.

https://gerrit.wikimedia.org/r/198443

kaldari added a comment.Mar 21 2015, 12:53 AM

Nevermind, looks like HHVM doesn't care about it either. Hmmm.

gerritbot added a comment.Mar 22 2015, 10:40 PM

Change 198658 had a related patch set uploaded (by Krinkle):
Add breaking tests for fatal error in TemplateParser

https://gerrit.wikimedia.org/r/198658

Krinkle added a subscriber: Krinkle.EditedMar 22 2015, 10:41 PM

Templates are not broken, the TemplateParser handler is broken. It produces invalid PHP for any template (no matter what) if there is no cache hit. This is a regression caused by the recent change that added a hashing token, but failed to cover this with unit tests. It never worked.

Legoktm added a subscriber: Legoktm.Mar 23 2015, 1:35 AM

I updated https://gerrit.wikimedia.org/r/198658 with a fix + tests.

gerritbot added a comment.Mar 23 2015, 1:54 AM

Change 198658 merged by jenkins-bot:
TemplateParser: Don't fatal on cache misses

https://gerrit.wikimedia.org/r/198658

Krinkle closed this task as Resolved.Mar 23 2015, 1:54 AM
gerritbot added a comment.Mar 23 2015, 2:11 AM

Change 198671 had a related patch set uploaded (by Alex Monk):
TemplateParser: Don't fatal on cache misses

https://gerrit.wikimedia.org/r/198671

gerritbot added a comment.Mar 23 2015, 2:21 AM

Change 198671 merged by jenkins-bot:
TemplateParser: Don't fatal on cache misses

https://gerrit.wikimedia.org/r/198671

gerritbot added a comment.Mar 23 2015, 2:24 AM

Change 198672 had a related patch set uploaded (by Alex Monk):
TemplateParser: Don't fatal on cache misses

https://gerrit.wikimedia.org/r/198672

gerritbot added a comment.Mar 23 2015, 3:05 AM

Change 198672 merged by jenkins-bot:
TemplateParser: Don't fatal on cache misses

https://gerrit.wikimedia.org/r/198672

Krenair mentioned this in rMW93da82367214: TemplateParser: Don't fatal on cache misses.Mar 23 2015, 3:51 PM
Krenair mentioned this in rMW17de7d40a46e: TemplateParser: Don't fatal on cache misses.
Krinkle mentioned this in rMWcfcaa33fcc42: TemplateParser: Don't fatal on cache misses.Mar 23 2015, 3:51 PM
Krinkle mentioned this in T93594: MediaWiki MobileFrontend test failure: Failing to assert that session ID is 16 chars long.Mar 23 2015, 5:49 PM
demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jun 12 2015, 6:35 PM
• Phabricator_maintenance moved this task from Incoming to 2014-15 Q3 on the Readers-Web-Backlog board.Mar 7 2018, 4:29 AM
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL