The OOUI hack to prevent scrolling while dialog is open causes page contents to move horizontally by scrollbar's width in RTL when dialog opens
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Mar 21 2015, 5:11 PM

Description

The OOUI hack to prevent scrolling while dialog is open causes page contents to move horizontally by scrollbar's width in RTL when dialog opens.

Caused by https://gerrit.wikimedia.org/r/#/c/196571/ which was a fix for T89612.

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.48.3	mediawiki/core	master	+1 K -1 K
	WindowManager: Fix faking scrollbar width on the wrong side in RTL	oojs/ui	master	+13 -14

Customize query in gerrit

Related Objects

Mentioned In: T349155: Consider using scrollbar-gutter property to prevent content from moving when a Dialog opens
T89612: The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens
Mentioned Here: T89612: The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens

Event Timeline

matmarex created this task.Mar 21 2015, 5:11 PM

matmarex assigned this task to Esanders.

matmarex raised the priority of this task from to Medium.

matmarex updated the task description. (Show Details)

matmarex added projects: OOUI, VisualEditor-MediaWiki, VisualEditor.

matmarex mentioned this in T89612: The OOUI hack to prevent scrolling while dialog is open causes pages to scroll when dialog opens.

matmarex added subscribers: Eloquence, matmarex, Aklapper.

To clarify: this only happens if your system if fully RTL, as most browsers don't take the outer window's directionality from the body/html. Even running Firefox in Hebrew on an English OS it is impossible to get the window scrollbar to flip.

Depends on the browser. Here's a screenshot of English IE 11 on English Windows 7 viewing https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/#dialogs-mediawiki-vector-rtl:

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Mar 25 2015, 10:01 PM

Esanders lowered the priority of this task from Medium to Low.Jun 8 2015, 2:18 PM

Esanders set Security to None.

Jdforrester-WMF moved this task from TR6: Visual diffs to Freezer on the VisualEditor board.Jun 18 2015, 12:36 AM

Jdforrester-WMF removed Esanders as the assignee of this task.Sep 16 2015, 11:42 PM

In T93476#1139074, @Esanders wrote:

To clarify: this only happens if your system if fully RTL, as most browsers don't take the outer window's directionality from the body/html. Even running Firefox in Hebrew on an English OS it is impossible to get the window scrollbar to flip.

This can be tested on Firefox without changing your entire OS language by setting 'layout.scrollbar.side' to '1' in about:config.

Change 966299 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[oojs/ui@master] WindowManager: Fix faking scrollbar width on the wrong side in RTL

https://gerrit.wikimedia.org/r/966299

gerritbot added a project: Patch-For-Review.Oct 16 2023, 9:22 PM

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/50dc373669/w

Also created an OOUI Demos page:
https://patchdemo.wmflabs.org/wikis/50dc373669/w/build/ooui/demos

matmarex claimed this task.Oct 16 2023, 9:38 PM

Catrope mentioned this in T349155: Consider using scrollbar-gutter property to prevent content from moving when a Dialog opens.Oct 18 2023, 12:35 AM

Change 966299 merged by jenkins-bot:

[oojs/ui@master] WindowManager: Fix faking scrollbar width on the wrong side in RTL

https://gerrit.wikimedia.org/r/966299

Maintenance_bot removed a project: Patch-For-Review.Oct 25 2023, 6:30 AM

Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/50dc373669/w/~~

Browser support seems good, but less than ideal (https://caniuse.com/mdn-css_properties_scrollbar-gutter)

~92% of Chrome and Firefox users. There's no Safari support but macOS uses overlay scrollbars by default. We don't have any stats on how many mac users have fixed scrollbars enabled, but it's probably quite low.

That said the failure mode here is not that drastic, just a little bit of movement when modal dialogs open and close.

matmarex closed this task as Resolved.Nov 27 2023, 7:41 PM

Change 980958 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[mediawiki/core@master] Update OOUI to v0.48.3

https://gerrit.wikimedia.org/r/980958

gerritbot added a project: Patch-For-Review.Dec 6 2023, 11:20 PM

Change 980958 merged by jenkins-bot: