Page MenuHomePhabricator

CC-BY-SA licensing icon not visible after installing MediaWiki 1.24.1
Open, LowPublic

Description

After my download and installation of MediaWiki 1.24.1 in a subdirectory of my web server using MacOS X, without alteration, it seems like the main page's footer does not display the cc-by-sa.png logo I specified for the license next to the "Powered by MediaWiki" logo. This is the $wgRightsIcon variable in LocalSettings.php:

$wgRightsIcon="{$wgResourceBasePath}/resources/assets/licenses/cc-by-sa.png";

It might be that $wgResourceBasePath is not defined. We probably need to check our LocalSettings.php generator.

Steps to reproduce:

  • Grab a copy of the latest stable (1.24.1)
  • Use the web installer and select a license footer (I used cc-by-sa)
  • Complete your installation and download LocalSettings.php. Make sure that you DO NOT alter LocalSettings.php after installation.

You should then see that no license footer is present in the footer next to the "Powered by MediaWiki" logo, or that your browser says the image does not exist. Chrome will display a ripped image in place of the license footer. Safari will display a question mark, and so on.

Event Timeline

DSCrowned raised the priority of this task from to Normal.
DSCrowned updated the task description. (Show Details)
DSCrowned added a subscriber: DSCrowned.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2015, 5:50 AM

I believe that the $wgResourceBasePath in that line should be $wgScriptPath instead. We need to check with this.

Aklapper lowered the priority of this task from Normal to Low.Mar 22 2015, 12:06 PM
Aklapper added a project: MediaWiki-General.
Aklapper set Security to None.
PleaseStand added subscribers: Catrope, PleaseStand.

I believe that the $wgResourceBasePath in that line should be $wgScriptPath instead. We need to check with this.

It was $wgScriptPath until ef26c7ad4fc4555f (by @Catrope). $wgResourceBasePath isn't currently usable in generated LocalSettings.php files because it is only afterward set to its default value ($wgScriptPath) in Setup.php.

Adding a line such as $wgResourceBasePath = $wgScriptPath; higher up in the generated file should fix the problem. Alternatively, we could just revert the changes to Installer.php. After all, in generated LocalSettings.php files, $wgScriptPath is already used for $wgLogo, and the distinction really only matters for sites such as Wikimedia's that serve assets from a separate hostname (e.g. bits.wikimedia.org).

saper added a subscriber: saper.Oct 23 2015, 10:04 PM

This is T75031 and also T116374, please test if https://gerrit.wikimedia.org/r/#/c/248321/ solves the problem.

saper renamed this task from Unable to find license directory after installation of stable to CC-BY-SA licensing icon not visible after installing MediaWiki 1.24.1.Oct 23 2015, 10:05 PM
saper moved this task from Backlog to In progress on the MediaWiki-Installer board.