Page MenuHomePhabricator
Create Task
Maniphest T93592

MWExtensionInspector should inherit from NodeInspector
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update inspector now it inherits from NodeInspectorEsandersmediawiki/extensions/wikihieromaster+1 -1
[BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspectorEsandersmediawiki/extensions/VisualEditormaster+53 -82
Update inspector now it inherits from NodeInspectorEsandersmediawiki/extensions/Mathmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 23 2015, 3:59 PM
Esanders claimed this task.
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: VisualEditor.
Esanders subscribed.
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMar 23 2015, 3:59 PM
gerritbot subscribed.Mar 23 2015, 4:00 PM

Change 198729 had a related patch set uploaded (by Esanders):
[BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector

https://gerrit.wikimedia.org/r/198729

gerritbot added a project: Patch-For-Review.Mar 23 2015, 4:00 PM

Change 198731 had a related patch set uploaded (by Esanders):
Update inspector now it inherits from NodeInspector

https://gerrit.wikimedia.org/r/198731

gerritbot added a comment.Mar 23 2015, 4:00 PM

Change 198733 had a related patch set uploaded (by Esanders):
Update inspector now it inherits from NodeInspector

https://gerrit.wikimedia.org/r/198733

Physikerwelt subscribed.Mar 23 2015, 4:41 PM

scc (850×1,046 px, 123 KB)
(Math extension without VisualEditor update)

Physikerwelt added a comment.Mar 24 2015, 7:13 PM

I guess we should test the changes to the Math extension after the VisualEditor changes got merged.
Is there any way to make this change non breaking and support both "interfaces" for a while.

Jdforrester-WMF triaged this task as Medium priority.Mar 25 2015, 9:34 PM
Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.
Jdforrester-WMF moved this task from Planned Maintenance to Blocked on the VisualEditor board.
Jdforrester-WMF added projects: Technical-Debt, VisualEditor-MediaWiki, VisualEditor 2014/15 Q4 blockers.Apr 8 2015, 8:52 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
gerritbot added a comment.Apr 8 2015, 11:16 PM

Change 198729 merged by jenkins-bot:
[BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector

https://gerrit.wikimedia.org/r/198729

Jdforrester-WMF mentioned this in rEVEDed4278912c7f: [BREAKING CHANGE] Make MWExtensionInspector inherit from NodeInspector.Apr 8 2015, 11:16 PM
gerritbot added a comment.Apr 8 2015, 11:16 PM

Change 198731 merged by jenkins-bot:
Update inspector now it inherits from NodeInspector

https://gerrit.wikimedia.org/r/198731

Jdforrester-WMF mentioned this in rEMATbe96c3d5e040: Update inspector now it inherits from NodeInspector.Apr 8 2015, 11:16 PM
Esanders mentioned this in rMEXTf401d979a5e2: Updated mediawiki/extensions Project: mediawiki/extensions/Math….Apr 8 2015, 11:17 PM
gerritbot added a comment.Apr 9 2015, 2:23 PM

Change 198733 merged by jenkins-bot:
Update inspector now it inherits from NodeInspector

https://gerrit.wikimedia.org/r/198733

Jdforrester-WMF mentioned this in rEHIEbb53b96a3b17: Update inspector now it inherits from NodeInspector.Apr 9 2015, 2:23 PM
Diffusion mentioned this in rMEXTb1f0b70b388d: Updated mediawiki/extensions Project: mediawiki/extensions/wikihiero….Apr 9 2015, 2:24 PM
Jdforrester-WMF closed this task as Resolved.Apr 15 2015, 7:30 PM
Jdforrester-WMF added a project: WMF-deploy-2015-04-15_(1.26wmf2).
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
Jdforrester-WMF removed a project: Patch-For-Review.Apr 15 2015, 7:35 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Apr 16 2015, 9:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits