Page MenuHomePhabricator

headingmode breaks inputbox extension
Closed, ResolvedPublic

Description

Author: michael.axelrod

Description:
Using mediawiki 1.7.1, DynamicPagelist2 0.64 and inputbox 0.1.1

The following example causes the inputbox extension to fail:

<inputbox>
type=search
bgcolor=#eeeeff
</inputbox>

<DPL>
category=News
ordermethod=category,firstedit
headingmode=definition
</DPL>

The output looks something like this:

UNIQ2a130ffb230fab9b-inputbox-27c225a86337436400000001-QINU

News

There are 3 articles in this category.

    * One
    * Two
    * Albany

This only happens using headingmode and when the inputbox extension is called
first on the page. For example the following reversal fo the wiki text actually
works fine:

<inputbox>
type=search
bgcolor=#eeeeff
</inputbox>

<DPL>
category=News
ordermethod=category,firstedit
headingmode=definition
</DPL>

So order matters! Also without the "headingmode" parameter inputbox works fine....


Version: unspecified
Severity: normal

Details

Reference
bz7361

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:25 PM
bzimport set Reference to bz7361.

michael.axelrod wrote:

I have made a duplicate bug report in hopes of alerting developers of both
extension projects. see: http://bugzilla.wikipedia.org/show_bug.cgi?id=7362

Please close duplicate bug report 7362 when this bug report is closed.

  • Bug 7362 has been marked as a duplicate of this bug. ***

cyril.dangerville wrote:

Bug fixed in release 0.7.1.

Cause:
The global function wfMsgExt() was called with 'parse' option when 'headingmode'
enabled. This resulted in the global parser being called recursively
($wgOut->parse(...)), which is bad. See
http://meta.wikimedia.org/wiki/MediaWiki_extensions_FAQ#How_do_I_render_wikitext_in_my_extension.3F
for more info.

Solution: reused the code from wfMsgExt but using a local parser instead of the
global one.

cyril.dangerville wrote:

Closed the bug.

jimmy.collins wrote:

Cyril, don't forget to add the svn release: r16596

rombiama wrote:

links: admin

<?xml version="1.0" encoding="utf-8"?>
<api>

<query>
  <pages>
    <page ns="0" title="Main Page" missing="www.angosso.com" />
  </pages>
  <backlinks />
</query>

</api>

Attached:

Don't know why this was re-opened. Been marked fixed since 2006.