Page MenuHomePhabricator
Create Task
Maniphest T93618

Bug: When public user visits another users collections page the Page header says "[usernames] collections"
Closed, ResolvedPublic
Actions

Description

Currently, if you go here: http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/by/Diablanco there is no h1 at the top of the page.
The view should be updated to include one.

Details

SubjectRepoBranchLines +/-
Differentiate between html <title> and page title on php viewsmediawiki/extensions/Gathermaster+20 -6
Customize query in gerrit

Related Objects

Event Timeline

• JKatzWMF created this task.Mar 23 2015, 6:00 PM
• JKatzWMF raised the priority of this task from to Needs Triage.
• JKatzWMF updated the task description. (Show Details)
• JKatzWMF subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2015, 6:00 PM
Aklapper added a project: Gather.Mar 23 2015, 7:04 PM

@JKatzWMF: Please always associate projects to tasks.

Jdlrobson moved this task from Needs triage to Product triage on the Gather board.Mar 24 2015, 9:47 PM
Jdlrobson renamed this task from When public user visits another users collections page the Page header says "[usernames] collections" to Bug: When public user visits another users collections page the Page header says "[usernames] collections".Apr 11 2015, 12:25 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Gather Sprint Forward.
Jdlrobson set Security to None.
Jdlrobson edited a custom field.
Jdlrobson edited a custom field.
Jdlrobson moved this task from Product triage to Bug backlog on the Gather board.
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Forward board.
Jdlrobson subscribed.Apr 13 2015, 10:41 PM

good first task

• Jhernandez claimed this task.Apr 16 2015, 12:51 PM
• Jhernandez moved this task from Ready for dev to In development on the Gather Sprint Forward board.
• Jhernandez mentioned this in T96245: Url /by/User completely broken.Apr 16 2015, 1:03 PM
• Jhernandez added a comment.Apr 16 2015, 4:20 PM

Actually, no other page than /Special:Gather/by/User/555 has a title. So I'm going to restore them all properly.

• Jhernandez added a project: Patch-For-Review.Apr 16 2015, 4:44 PM

Patch is here https://gerrit.wikimedia.org/r/#/c/204537/ for review. Not sure why gerrit bot and jenkins are ignoring me.

It is not verified because chromium as usual is timing out (yayyy!)

• Jhernandez moved this task from In development to Code review needed on the Gather Sprint Forward board.Apr 16 2015, 4:45 PM
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Forward board.Apr 16 2015, 5:19 PM
gerritbot subscribed.Apr 16 2015, 5:21 PM

Change 204537 merged by jenkins-bot:
Differentiate between html <title> and page title on php views

https://gerrit.wikimedia.org/r/204537

Diffusion mentioned this in rMEXT2cef348ffc08: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Apr 16 2015, 5:22 PM
Diffusion mentioned this in rEGAT4b3f282ad28e: Differentiate between html <title> and page title on php views.
Jdlrobson moved this task from Bug backlog to In sprint on the Gather board.Apr 16 2015, 5:36 PM
• JKatzWMF closed this task as Resolved.Apr 27 2015, 4:34 AM
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Forward board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL