Page MenuHomePhabricator
Create Task
Maniphest T93720

In Hovercards, HTML is sometimes showing, e.g. apostrophes are shown as '
Closed, ResolvedPublic
Actions

Description

In Hovercards, apostrophes are shown as ' and quotation marks as "
Test with [["Heroes"]] at https://en.wikipedia.org/wiki/Wikipedia:Article_titles#Article_title_format
or with [[Hubble's law]] at https://en.wikipedia.org/wiki/List_of_laws#Astronomy_and_cosmology_laws

Screenshot_from_2015-03-23_23:35:29.png (325×578 px, 109 KB)

However! It's not consistent...
The cards linked from everything here, work properly: https://en.wikipedia.org/wiki/Don%27t
I haven't deduced a pattern...? (but also sleepy)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
renderer.article.getProcessedElements: Stop escaping the title and the extractmediawiki/extensions/Popupsmaster+11 -7
Customize query in gerrit

Related Objects

Event Timeline

Quiddity created this task.Mar 24 2015, 6:48 AM
Quiddity assigned this task to • Prtksxna.
Quiddity raised the priority of this task from to High.
Quiddity updated the task description. (Show Details)
Quiddity added a project: Page-Previews.
Quiddity subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2015, 6:48 AM
Se4598 merged a task: T93341: an apostrophe is escaped unnecessarily in a hovercard.Mar 24 2015, 10:41 AM
Se4598 added subscribers: Ricordisamoa, Amire80.
• Prtksxna added a comment.Mar 25 2015, 6:17 AM

This is happening on the Astronomy page and not on the Don't page because in the Astronomy page the article titles can be bolded in the excerpt. It happening because in article.getProcessedElements we mw.html.escape( title ).

gerritbot subscribed.Mar 26 2015, 8:15 AM

Change 199840 had a related patch set uploaded (by Prtksxna):
renderer.article: Use .html() instead of .text() in getProcessesElements

https://gerrit.wikimedia.org/r/199840

gerritbot added a project: Patch-For-Review.Mar 26 2015, 8:15 AM
• Prtksxna mentioned this in T88171: Overall security review of Popups/Hovercards extension.Mar 26 2015, 10:44 AM
MC8 subscribed.Mar 26 2015, 12:52 PM
Se4598 merged a task: T94021: Hover cards shows entities in final result instead of ' or " characters..Mar 26 2015, 12:57 PM
Se4598 added a subscriber: TheDJ.
Aklapper merged a task: T94135: Popups extension encoding bug.Mar 27 2015, 11:20 AM
Aklapper added a subscriber: aaron.
gerritbot added a comment.Mar 27 2015, 6:45 PM

Change 199840 merged by jenkins-bot:
renderer.article.getProcessedElements: Stop escaping the title and the extract

https://gerrit.wikimedia.org/r/199840

Diffusion mentioned this in rMEXT11e51870cfce: Updated mediawiki/extensions Project: mediawiki/extensions/Popups….Mar 27 2015, 6:46 PM
• Prtksxna mentioned this in rEPOP20f2bef27240: renderer.article.getProcessedElements: Stop escaping the title and the extract.Mar 27 2015, 6:46 PM
TheDJ closed this task as Resolved.Mar 29 2015, 5:00 PM
TheDJ moved this task from Backlog to Done on the Page-Previews board.
TheDJ removed a project: Patch-For-Review.
TheDJ set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits