Page MenuHomePhabricator

Access request: +2 on cassandra submodule for services team members
Closed, DeclinedPublic

Description

Services is currently handling most of the administrative tasks around the RESTBase cassandra cluster. In that capacity, we often need to tweak the cassandra submodule. Currently the development process for these changes is less than ideal, as each change requires two +2s from ops, one for the puppet/cassandra repository change & one for the submodule update. The other issue is that we can't use the puppet compiler to check changes until a change is merged in the submodule.

@Eevans created a patch to eliminate the submodule at https://gerrit.wikimedia.org/r/#/c/196335/, but this met resistance from Andrew because it would complicate the reuse of this submodule in Vagrant.

Instead, we could consider granting +2 rights on the cassandra submodule to services members (@Eevans, @mobrovac, myself). This would eliminate the second ops review, and we can test merged changes in the submodule with the puppet compiler before asking for +2 for the submodule update in puppet proper.

Event Timeline

GWicke raised the priority of this task from to Needs Triage.
GWicke updated the task description. (Show Details)
GWicke added subscribers: GWicke, Eevans, mobrovac.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
GWicke set Security to None.
GWicke updated the task description. (Show Details)

I'm fine with +2 for cassandra puppet repo, but I somehow doubt other opsens will like it.

The other issue is that we can't use the puppet compiler to check changes until a change is merged in the submodule.

Are you sure about this? Other submodules get checked. You just need to tell jenkins to check this repo:
https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L2678

Either way, you will have to get review from opsen, cause they aren't going to give you +2 on operations/puppet. Why not just accompany the submodule change with the operations/puppet submodule update change at the same time? That way whomever is reviewing will be able to merge both at once.

I'm fine with +2 for cassandra puppet repo, but I somehow doubt other opsens will like it.

The other issue is that we can't use the puppet compiler to check changes until a change is merged in the submodule.

Are you sure about this? Other submodules get checked. You just need to tell jenkins to check this repo:
https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L2678

I don't see anything there that indicates that puppet submodules work with the puppet compiler. If there is a way to do that, then please let us know.

Dzahn triaged this task as Medium priority.Mar 31 2015, 5:12 PM
Dzahn added a subscriber: Dzahn.

@Ottomata, will adding a line like that allow us to check the changes a submodule patch will cause in the production config ahead of time? Would it allow us to enter a submodule patch number into https://integration.wikimedia.org/ci/job/operations-puppet-catalog-compiler/build?delay=0sec and have it be compiled as part of a full puppet run?

No, it won't. It will just do the regular puppet lints. However, I think you could still do this with the second commit that updates the submodule SHA.

Ottomata closed subtask Restricted Task as Invalid.Apr 13 2015, 6:45 PM
RobH claimed this task.
RobH added a subscriber: RobH.

This has been stated that it will move into operations/puppet and thus this request is rejected. Closing.