Page MenuHomePhabricator
Create Task
Maniphest T93836

Undefined index: 1 in PhpDateTimeParser.php on line 180 (and sometimes line 179)
Closed, ResolvedPublic
Actions

Description

Mar 24 23:17:51 mw1123: #012Notice: Undefined index: 1 in /srv/mediawiki/php-1.25wmf22/extensions/Wikidata/extensions/Wikibase/lib/includes/parsers/PhpDateTimeParser.php on line 180
Mar 24 23:17:52 mw1230: #012Notice: Undefined index: 1 in /srv/mediawiki/php-1.25wmf22/extensions/Wikidata/extensions/Wikibase/lib/includes/parsers/PhpDateTimeParser.php on line 179

Details

SubjectRepoBranchLines +/-
Fix isset() check in PhpDateTimeParsermediawiki/extensions/Wikibasewmf/1.25wmf22+4 -1
Fix isset() check in PhpDateTimeParsermediawiki/extensions/Wikibasemaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

aude created this task.Mar 25 2015, 1:17 AM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2015, 1:17 AM
Lydia_Pintscher added subscribers: Lydia_Pintscher, thiemowmde, hoo, JanZerebecki.Mar 25 2015, 9:32 AM
gerritbot subscribed.Mar 25 2015, 11:37 AM

Change 199604 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix isset() check in PhpDateTimeParser

https://gerrit.wikimedia.org/r/199604

gerritbot added a project: Patch-For-Review.Mar 25 2015, 11:37 AM
thiemowmde added a comment.EditedMar 25 2015, 11:40 AM

Turns out, this is an HHVM-only thingy. There are even test cases that should have triggered this, but PHP suppresses this notice and neither my machine nor Jenkins complained because we both don't have a HHVM test run (now tracked in T93871).

I double-checked and my mistake in the code does not cause any harm other than the notices in the logs. This issue is only triggered for invalid dates that can't be parsed by that parser anyway. It fails anyway in a later step.

However, the patch can be backported in my opinion if you care about clean logs.

Lydia_Pintscher added a project: § Wikidata-Sprint-2015-03-24.Mar 25 2015, 11:48 AM
Lydia_Pintscher set Security to None.
gerritbot added a comment.Mar 25 2015, 11:49 AM

Change 199604 merged by jenkins-bot:
Fix isset() check in PhpDateTimeParser

https://gerrit.wikimedia.org/r/199604

thiemowmde mentioned this in rMEXTe60a2b45bb54: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 25 2015, 11:50 AM
thiemowmde mentioned this in rEWBA13ecc63c3fea: Fix isset() check in PhpDateTimeParser.
gerritbot added a comment.Mar 25 2015, 12:50 PM

Change 199612 had a related patch set uploaded (by Aude):
Fix isset() check in PhpDateTimeParser

https://gerrit.wikimedia.org/r/199612

hoo closed this task as Resolved.Mar 25 2015, 12:51 PM
hoo claimed this task.
gerritbot added a comment.Mar 25 2015, 1:00 PM

Change 199612 merged by jenkins-bot:
Fix isset() check in PhpDateTimeParser

https://gerrit.wikimedia.org/r/199612

aude mentioned this in rEWBA4ebc686a0355: Fix isset() check in PhpDateTimeParser.Mar 25 2015, 1:01 PM
Tobi_WMDE_SW moved this task from Backlog to Done on the § Wikidata-Sprint-2015-03-24 board.Mar 26 2015, 10:26 AM
Ricordisamoa removed a project: Patch-For-Review.Jul 6 2015, 10:37 PM
Ricordisamoa edited subscribers, added: Ricordisamoa; removed: gerritbot.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL