Page MenuHomePhabricator
Create Task
Maniphest T93864

Focus not in main snak value after selecting a property with mouse
Closed, ResolvedPublic
Actions

Description

  1. I am entering a new statement, starting with selecting a property.
  1. I choose a property with mouse click
  1. focus is not in the main snak value field

pasted_file (221×988 px, 13 KB)

Details

SubjectRepoBranchLines +/-
Fix focus on value field on property selectmediawiki/extensions/Wikibasewmf/1.25wmf22+39 -53
Fix focus on value field on property selectmediawiki/extensions/Wikibasemaster+39 -53
Customize query in gerrit

Related Objects

Event Timeline

aude created this task.Mar 25 2015, 10:03 AM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added projects: Wikidata, MediaWiki-extensions-WikibaseRepository.
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2015, 10:03 AM
aude added a comment.Mar 25 2015, 10:05 AM

if i select a property with down arrow and then enter, focus also does not move to the value field

aude added a comment.Mar 25 2015, 10:07 AM

on master, on my dev wiki, focus goes to the "add qualifier" link after I select a property. I am not sure this happens on wikidata.

pasted_file (362×1 px, 27 KB)

gerritbot subscribed.Mar 26 2015, 2:44 PM

Change 199910 had a related patch set uploaded (by Aude):
Set _focusToValueView on entityselectorselected event in snakview

https://gerrit.wikimedia.org/r/199910

gerritbot added a project: Patch-For-Review.Mar 26 2015, 2:44 PM
aude added a project: § Wikidata-Sprint-2015-03-24.Mar 26 2015, 3:18 PM
aude set Security to None.
aude moved this task from Backlog to Review on the § Wikidata-Sprint-2015-03-24 board.
Lydia_Pintscher triaged this task as Medium priority.Mar 30 2015, 9:46 AM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Mar 30 2015, 12:44 PM
gerritbot added a comment.Mar 30 2015, 1:36 PM

Change 199910 merged by jenkins-bot:
Fix focus on value field on property select

https://gerrit.wikimedia.org/r/199910

Diffusion mentioned this in rMEXTc933476ab4d7: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 30 2015, 1:36 PM
aude mentioned this in rEWBAdd689a38e7c3: Fix focus on value field on property select.Mar 30 2015, 1:36 PM
daniel closed this task as Resolved.Mar 30 2015, 1:42 PM
daniel claimed this task.
daniel subscribed.

merged

aude claimed this task.Mar 30 2015, 1:43 PM
daniel moved this task from Review to Done on the § Wikidata-Sprint-2015-03-24 board.Mar 30 2015, 2:00 PM
gerritbot added a comment.Mar 30 2015, 6:52 PM

Change 200640 had a related patch set uploaded (by Aude):
Fix focus on value field on property select

https://gerrit.wikimedia.org/r/200640

gerritbot added a comment.Mar 30 2015, 7:16 PM

Change 200640 merged by jenkins-bot:
Fix focus on value field on property select

https://gerrit.wikimedia.org/r/200640

aude mentioned this in rEWBA5f60c2fcdd1e: Fix focus on value field on property select.Mar 30 2015, 7:16 PM
aude removed a project: Patch-For-Review.Mar 30 2015, 8:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL