Page MenuHomePhabricator

[Task] Consolidate "Created a new item" summary line messages
Closed, DeclinedPublic

Description

We currently have 4 identical "Created a new item" messages.

"wikibase-item-summary-wbsetitem": "Created a new item",
"wikibase-item-summary-wbcreate-new": "Created a new item",
"wikibase-item-summary-wbeditentity": "Created a new item",
"wikibase-item-summary-wbeditentity-create": "Created a new item",

But only two for properties:

"wikibase-property-summary-wbcreate-new": "Created a new property",
"wikibase-property-summary-wbeditentity-create": "Created a new property",

Especially the wbeditentity message key is misleading. It caused T93853. It looks like it's supposed to be used as a fallback for unspecified edits but can't used as such.

To do:

  • Find out where the messages are used.
  • Find out why the property messages are missing and if that's a problem.
  • Remove unused messages.
  • Possibly consolidate to a single message for each entity type.

Event Timeline

thiemowmde raised the priority of this task from to Low.
thiemowmde updated the task description. (Show Details)
thiemowmde added a project: Wikidata.
thiemowmde added a subscriber: thiemowmde.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2015, 10:14 AM
thiemowmde set Security to None.Mar 25 2015, 10:15 AM
thiemowmde added subscribers: Lucie, aude.
This comment was removed by matej_suchanek.
Jonas renamed this task from Consolidate "Created a new item" summary line messages to [Task] Consolidate "Created a new item" summary line messages.Sep 10 2015, 11:11 AM
Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 26 2017, 11:45 PM
thiemowmde closed this task as Declined.Feb 28 2018, 4:06 PM

The first two message keys are not used in the code any more, but must stay because there are still edit summaries with these message keys in the database. qqq.json describes these messages as such. Therefore consolidation is not easily possible (well, it is, but we would lose localization for some of these old summaries, and should only do so if we are sure this is ok). Closing for now as this is a really minor issue probably not worth anybodies time.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptFeb 28 2018, 4:07 PM