Maniphest T93891

Change isComplete to query step objects instead of upload objects
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	MarkTraceur
	Mar 25 2015, 2:58 PM

Tags

Referenced Files

None

Subscribers

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Move allowCloseWindow around until it makes sense	mediawiki/extensions/UploadWizard	master	+37 -30

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T96906 Refactor UploadWizard to be maintainable
		Resolved		matthiasmullie	T93895 Remove this.uploads from the UploadWizard class
		Resolved		MarkTraceur	T93893 Move startUploads into the upload step controller
		Resolved		MarkTraceur	T93892 Move showNext into the step controllers (and simplify it)
		Resolved		MarkTraceur	T93891 Change isComplete to query step objects instead of upload objects

Event Timeline

This method is in mw.UploadWizard.js and it accesses this.uploads unnecessarily

MarkTraceur set Security to None.Mar 25 2015, 2:58 PM

MarkTraceur edited a custom field.

MarkTraceur added a parent task: T93895: Remove this.uploads from the UploadWizard class.Mar 25 2015, 3:07 PM

MarkTraceur edited a custom field.Mar 25 2015, 3:40 PM

• Gilles edited projects, added Multimedia-Sprint-2015-03-25; removed Multimedia-Sprint-2015-03-18.Mar 25 2015, 3:44 PM

Change 199898 had a related patch set uploaded (by MarkTraceur):
Move allowCloseWindow around until it makes sense

https://gerrit.wikimedia.org/r/199898

gerritbot added a project: Patch-For-Review.Mar 26 2015, 2:20 PM

MarkTraceur moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-03-25 board.Mar 26 2015, 2:21 PM

Change 199898 merged by jenkins-bot:
Move allowCloseWindow around until it makes sense

https://gerrit.wikimedia.org/r/199898

MarkTraceur mentioned this in rMEXT7e74800d0a5a: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 27 2015, 4:44 PM

MarkTraceur mentioned this in rEUWI52016c78fda0: Move allowCloseWindow around until it makes sense.

• Gilles moved this task from Needs code review to Ready for testing on the Multimedia-Sprint-2015-03-25 board.Mar 30 2015, 7:27 AM

MarkTraceur added a parent task: T96906: Refactor UploadWizard to be maintainable.Apr 22 2015, 8:08 PM

matmarex closed this task as Resolved.Apr 24 2015, 6:33 PM

matmarex subscribed.

matmarex moved this task from Backlog to Finished on the UploadWizard-Refactoring board.Apr 24 2015, 6:38 PM