Remove unnecessary Graphoid code inherited from the template (in routes/)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mvolz
	Mar 25 2015, 6:05 PM

Details

	Subject	Repo	Branch	Lines +/-
	Deleted unneeded code from service template	mediawiki/services/graphoid	master	+0 -264

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Yurik	T87406 Deploy Graph Extension to all Wikipedias
Resolved	Yurik	T73227 Graph extension does not have a fallback for non-JavaScript browsers
Resolved	akosiaris	T90487 Deploy graphoid service into production
Resolved	Yurik	T93881 Improve Graphoid code
Resolved	Yurik	T93919 Remove unnecessary Graphoid code inherited from the template (in routes/)

Event Timeline

Mvolz created this task.Mar 25 2015, 6:05 PM

Mvolz assigned this task to Yurik.

Mvolz raised the priority of this task from to High.

Mvolz updated the task description. (Show Details)

Mvolz added projects: Services, MediaWiki-extensions-Graph.

Mvolz added a parent task: T89287: Graph editing in VisualEditor.

Mvolz added subscribers: • mobrovac, Aklapper, Mvolz.

Mvolz mentioned this in T89287: Graph editing in VisualEditor.Mar 25 2015, 6:14 PM

Mvolz removed Yurik as the assignee of this task.Mar 25 2015, 6:17 PM

Mvolz removed a parent task: T89287: Graph editing in VisualEditor.

Mvolz set Security to None.

• mobrovac mentioned this in T93881: Improve Graphoid code.Mar 26 2015, 9:44 AM

Yurik renamed this task from Remove unnecessary code inherited from the template (in routes/) to Remove unnecessary Graphoid code inherited from the template (in routes/).Apr 6 2015, 6:30 AM

@mobrovac, which of these routes do you think should be kept?

empty.js.template -- probably not needed
ex.js     -- shows Error usage, but I have my own Err object (please review) in v1.js. So ex.js is probably not needed
info.js   -- handles the _info/*, seems useful
root.js   -- handles /robots.txt, probably need

Change 202004 had a related patch set uploaded (by Yurik):
Deleted unneeded code from service template

https://gerrit.wikimedia.org/r/202004

gerritbot added a project: Patch-For-Review.Apr 6 2015, 6:40 AM

Yurik closed this task as Resolved.Apr 6 2015, 9:02 PM

Yurik claimed this task.

Change 202004 merged by Yurik:
Deleted unneeded code from service template

https://gerrit.wikimedia.org/r/202004

Yurik mentioned this in rGGRA92f4efd47b2c: Deleted unneeded code from service template.Apr 8 2015, 4:36 PM

• mobrovac removed a project: Patch-For-Review.Apr 9 2015, 9:27 AM

Yurik moved this task from Backlog to Graphoid on the MediaWiki-extensions-Graph board.Apr 16 2015, 4:03 PM

Ricordisamoa added a project: Graphoid.Apr 16 2015, 9:12 PM

Ricordisamoa subscribed.