Page MenuHomePhabricator
Create Task
Maniphest T93933

Edit workflow broken
Closed, ResolvedPublic
Actions

Description

Visiting http://en.m.wikipedia.beta.wmflabs.org/wiki/Special:Gather/by/Jdlrobson/5 and clicking edit doesn't work.
JS exception thrown

Details

SubjectRepoBranchLines +/-
Rework init script for Special:Gathermediawiki/extensions/Gathermaster+3 -9
Regression: Fix typo, fix editing workflowmediawiki/extensions/Gathermaster+1 -1
Fix typing errormediawiki/extensions/Gathermaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFlorianT93933 Edit workflow broken
 ResolvedJdlrobsonT93949 Add browser test for edit workflow

Event Timeline

Jdlrobson created this task.Mar 25 2015, 7:25 PM
Jdlrobson assigned this task to Florian.
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Gather Sprint Diplodocus.
Jdlrobson moved this task to Ready for dev on the Gather Sprint Diplodocus board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2015, 7:25 PM
Jdlrobson moved this task from Ready for dev to Needs more development (-1) on the Gather Sprint Diplodocus board.Mar 25 2015, 7:25 PM
gerritbot subscribed.Mar 25 2015, 7:26 PM

Change 199663 had a related patch set uploaded (by Jdlrobson):
Fix undefined length on Special:Gather

https://gerrit.wikimedia.org/r/199663

gerritbot added a project: Patch-For-Review.Mar 25 2015, 7:26 PM
Jdlrobson triaged this task as High priority.Mar 25 2015, 9:12 PM

Annoyingly the workflow is still broken.
When I click save I get Uncaught TypeError: undefined is not a function

gerritbot added a comment.Mar 25 2015, 9:24 PM

Change 199743 had a related patch set uploaded (by Jdlrobson):
Regression: Fix typo, fix editing workflow

https://gerrit.wikimedia.org/r/199743

Jdlrobson mentioned this in T93898: Editor guider confusing browser tests.Mar 25 2015, 9:26 PM
gerritbot added a comment.Mar 25 2015, 9:28 PM

Change 199683 had a related patch set uploaded (by Florianschmidtwelzow):
Fix typing error

https://gerrit.wikimedia.org/r/199683

gerritbot added a comment.Mar 25 2015, 9:28 PM

Change 199683 abandoned by Florianschmidtwelzow:
Fix typing error

Reason:
Fixed with Ie6aaaa049078556ed4c0097a4420dd47bf3a4f5a

https://gerrit.wikimedia.org/r/199683

gerritbot added a comment.Mar 25 2015, 9:29 PM

Change 199743 merged by jenkins-bot:
Regression: Fix typo, fix editing workflow

https://gerrit.wikimedia.org/r/199743

Diffusion mentioned this in rMEXTb2fbaa122cd6: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Mar 25 2015, 9:30 PM
Jdlrobson merged a task: T93951: Cannot submit collection edits.Mar 25 2015, 10:19 PM
Jdlrobson added a subscriber: • JKatzWMF.
Jdlrobson closed this task as Resolved.Mar 25 2015, 10:29 PM

This is now working.

Jdlrobson moved this task from Needs more development (-1) to Ready for signoff on the Gather Sprint Diplodocus board.Mar 25 2015, 10:31 PM
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Diplodocus board.Mar 26 2015, 12:52 AM
gerritbot added a comment.Mar 27 2015, 7:51 PM

Change 199663 merged by jenkins-bot:
Rework init script for Special:Gather

https://gerrit.wikimedia.org/r/199663

Diffusion mentioned this in rMEXTc292fb7a4a49: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Mar 27 2015, 7:52 PM
Jdlrobson closed subtask T93949: Add browser test for edit workflow as Resolved.Apr 1 2015, 3:16 PM
Jdlrobson mentioned this in rEGATe80133ec72b4: Regression: Fix typo, fix editing workflow.Apr 8 2015, 6:17 PM
Florian mentioned this in rEGAT2b2be96a795c: Rework init script for Special:Gather.Apr 8 2015, 6:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL