Page MenuHomePhabricator
Create Task
Maniphest T93935

When splitting a paragraph, trim whitespace from the start of the new one
Closed, ResolvedPublic
Actions

Description

See https://en.wikipedia.org/w/index.php?title=Convenience_food&diff=612944999&oldid=609370408

Steps to Reproduce: Take an existing text, and insert a new paragraph at the end of a word but before the next space. The space is then carried over to be the first character of the next paragraph. It gets nowikied in order no to create a preformatted line.

Suggestion: Remove spaces at the beginning of paragraphs, as they'll get nowiki'ed. If there are cases where we actually want that, then instead of removing them on save, we could remove them during the creation of the paragraph, and only keep them if they're added manually by the user after the creation of the paragraph.

Related Objects

Event Timeline

Jdforrester-WMF created this task.Mar 25 2015, 7:43 PM
Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki.
Jdforrester-WMF added subscribers: Jdforrester-WMF, Whatamidoing-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2015, 7:43 PM
Jdforrester-WMF mentioned this in T68628: Spaces at the start of a paragraph aren't very obvious.Mar 25 2015, 7:43 PM
Elitre added a subscriber: Elitre.Mar 25 2015, 7:48 PM
gpaumier added a subscriber: gpaumier.Mar 25 2015, 7:54 PM
gpaumier set Security to None.Mar 25 2015, 9:14 PM
gpaumier added a subscriber: Eloquence.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Mar 25 2015, 10:00 PM
gpaumier added a project: VisualEditor 2014/15 Q3 blockers.Mar 31 2015, 5:41 PM
Catrope added a subscriber: Catrope.Mar 31 2015, 7:01 PM

The linked diff is 9 months old. Using the instructions I can't reproduce this any more: pressing Enter in "Foo Bar" to create "Foo" and " Bar" in the editor results in "Foo\n\nBar" in wikitext.

Jdforrester-WMF closed this task as Resolved.Apr 1 2015, 12:18 AM
Jdforrester-WMF removed a project: VisualEditor 2014/15 Q3 blockers.
Etonkovidova added a subscriber: Etonkovidova.Apr 2 2015, 11:32 PM

The inserted paragraphs have visible extra leading spaces in VE:
<span typeof="mw:Nowiki" id="mwSQ" class="ve-ce-mwNowikiAnnotation">&nbsp; </span>

Can it be just to copying text (from somewhere) with those &nbsp;?

Catrope added a comment.Apr 2 2015, 11:33 PM

I think it might be that wrapper paragraphs (a special type of paragraph) bypass the whitespace stripping code, but that's just a theory.

The diff you showed me earlier didn't look like a copy-paste diff, it looked like the user was removing a bunch of stuff.

gpaumier mentioned this in T94767: Perform a weekly review of edits made with VisualEditor.Apr 3 2015, 5:50 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.Aug 5 2015, 1:19 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL