Page MenuHomePhabricator

Regression on Checkboxes and radio buttons
Closed, ResolvedPublic1 Estimated Story Points


They used to be larger. See pholios attached.

Event Timeline

violetto raised the priority of this task from to Needs Triage.
violetto updated the task description. (Show Details)
violetto added a subscriber: violetto.

This needs to be reverted, after this change form elements no longer align.

Sorry to clarify, the margins portions of the patches are probably fine, but need to be broken out from the sizing changes which need to be reverted .

Indepedently, the checkbox also uses the pre-existing icon, rather than the one from mockups. Seems like there is a "tick" icon in WikiFont (or whatever the name is now), but it was discarded when we imported the icons in 06a5031fd3bf6f25f2398aff2b4999bfe224b463, as it doesn't match the mockup either (and it looked just plain ugly when I tried it right now). I'm submitting a patch for that; not touching the sizes now.

Change 200635 had a related patch set uploaded (by Bartosz Dziewoński):
MediaWiki theme: Use checkbox icon per mockups

@matmarex this task is referring to the change in the OVERALL size of the control, not the size of the graphics WITHIN the control.

Okay. In the future, I will refrain from trying to implement the parts of design changes that can be implemented immediately, if there's some detail blocking the rest.

Change 200635 merged by jenkins-bot:
MediaWiki theme: Use checkbox icon per mockups

@matmarex, not entirely sure what happened during the import. But here is the checkmark icon attached here [1] and in Dropbox where the rest of the icons are at.

Speaking of icons: T94461


Checkmark icon on Dropbox

Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF edited a custom field.
Prtksxna added a subscriber: Jdforrester-WMF.

@Jdforrester-WMF, the patch that @matmarex submitted - rGOJUe0d015e20f0d - although useful, doesn't resolve this issue.
Please also see my comment on T86003#1177354.

Jdforrester-WMF changed the task status from Duplicate to Resolved.May 6 2015, 10:18 PM

Hey @Jdforrester-WMF, I'm reopening this, although it's a dupe because it's not yet solved.

Here's the latest:

Screenshot 2015-05-06 15.27.00.png (194×408 px, 10 KB)

Jdforrester-WMF claimed this task.

The bit of this task that needed fixing for Editing Q4 is fixed. Please follow-up with further comments on T86003.