Page MenuHomePhabricator

Technical Debt: Eliminate all state from Cite.references object
Closed, ResolvedPublic

Description

Since refs are now generated in a single pass over the final DOM, there is no reason to maintain state in the globally-shared Cite objects. It should be possible to pass state as a param to the associated functions which will basically make the reset functions no-ops.

This would have prevented the id reuse issues reported in T63165 and T93715.

Event Timeline

ssastry raised the priority of this task from to Medium.
ssastry updated the task description. (Show Details)
ssastry added a project: Parsoid.
ssastry subscribed.

Change 200881 had a related patch set uploaded (by Marcoil):
T93973: Remove state from Cite extension

https://gerrit.wikimedia.org/r/200881

Change 200881 merged by jenkins-bot:
T93973: Remove state from Cite extension

https://gerrit.wikimedia.org/r/200881