Page MenuHomePhabricator

Remove AjaxDispatcher use from Collection
Open, HighPublic

Description

Still being used as of 2015:
https://github.com/wikimedia/mediawiki-extensions-Collection/blob/110e53d9/Collection.php#L259

This has been deprecated for many years now.

This has many problems including making translation impossible.

Event Timeline

Krinkle created this task.Mar 26 2015, 6:26 AM
Krinkle raised the priority of this task from to High.
Krinkle updated the task description. (Show Details)
Krinkle added a subscriber: Aklapper.
cscott claimed this task.Mar 31 2015, 6:18 PM
cscott added a subscriber: cscott.

I'm adopting Krenair's patch to split it apart, get it reviewed, and push it over the finish line.

Change 183228 had a related patch set uploaded (by Cscott):
T94005: Clean up JS and change action=ajax stuff into API modules

https://gerrit.wikimedia.org/r/183228

Krenair renamed this task from Remove AjaxDispatcher from Collection to Remove AjaxDispatcher use from Collection.May 20 2015, 2:01 PM
Krenair set Security to None.

Change 183228 had a related patch set uploaded (by Reedy):
[WIP] Clean up JS and change action=ajax stuff into API modules

https://gerrit.wikimedia.org/r/183228

Change 183228 abandoned by Alex Monk:
[WIP] Clean up JS and change action=ajax stuff into API modules

https://gerrit.wikimedia.org/r/183228

Change 183228 restored by Alex Monk:
[WIP] Clean up JS and change action=ajax stuff into API modules

Reason:
There were problems I was running into due to some mistakes while rebasing, and I gave up for a while. I'll look into fixing it later

https://gerrit.wikimedia.org/r/183228

Krinkle removed a subscriber: Krinkle.Sep 22 2017, 6:16 PM

@Jdlrobson: Is Watching really the right place for this since you're trying to get the change merged?

Also, y'know, good luck!

@bmansurov @pmiazga and I have agreed to focus on the rendering code and drop work on this since it doesn't help our cause so this patch is probably as far as it will go now sadly unless @cscott or someone else has bandwidth to help. We will watch it until that happens. There is a lot of work here to be done.