Graphoid uses one of the first versions of [Deprecated] service-template-node . It should be upgraded to the latest one, as it includes many improvements, such as automatic request logging, request ID generation, and auto-magic error handling.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Merged with upstream service-template-node | mediawiki/services/graphoid | master | +1 K -168 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Yurik | T87406 Deploy Graph Extension to all Wikipedias | |||
| Resolved | Yurik | T73227 Graph extension does not have a fallback for non-JavaScript browsers | |||
| Resolved | akosiaris | T90487 Deploy graphoid service into production | |||
| Resolved | Yurik | T93881 Improve Graphoid code | |||
| Resolved | Yurik | T94013 Update Graphoid to the latest version of service-template-node |
Event Timeline
Comment Actions
The git trees have diverged, and I have commited my fork as graphoid service in gerrit. What would be the best way to merge it? I tried git merge upstream/master, but git review shows too many patches, and i suspect it will break the system. Are we officially switching away from gerrit for the services?
Comment Actions
You should squash the changes into a single commit and review. Seeing that you are merging changes from a remote, though, something like this ought to be enough:
git merge --squash upstream/master
Are we officially switching away from gerrit for the services?
No, not at all. We have mistakenly started working on it in GH, as we were using it for RESTBase (mainly for its integration with travis which allowed us to test RESTBase in conjunction with Cassandra). At this point, however, there's a general plan to migrate to Phabricator, so we'll likely get on that sooner than others.
Comment Actions
Change 201998 had a related patch set uploaded (by Yurik):
Merged with upstream service-template-node