I thought Quim proposed to list the changesets which didn't get any comment at all. CR = 0 is something else: comments without CR labels, or no new comments after latest patchset.

Checking the latest CR labels is very easy and could be done in minutes on https://www.mediawiki.org/wiki/Gerrit/Reports/Oldest_open_changesets , but it's already provided by gerrit GUI and gerrit queries, e.g. https://gerrit.wikimedia.org/r/#/q/is:open+label:Code-Review%253D0,n,z (GUI is paginated, though).

Just a question, if a changeset is on -1 but then a new upload is made, then it is considered 0, right? If so, we should list only those changesets that didn't get any review ever.

if a changeset is on -1 but then a new upload is made, then it is considered 0, right?

Yes.

Hi,

I'd like to confirm some examples:

For instance, according to the Korma database and checking the Gerrit site, the two oldest changesets without any review would be:

• https://gerrit.wikimedia.org/r/#/c/4055/
• https://gerrit.wikimedia.org/r/#/c/25903/

In both cases, there's not a "Code Review" and there's no WIP. And they did not have a review ever for any patchset at all.

However they have some activity such as comments, Verifications by Jenkins and inline comments.

Would that be the list of changesets that you're willing to list in this task?

Yes, I think we should keep the rules simple and list these as well.

Even if these two changesets don't represent the case of a Gerrit change that has received no feedback at all, I stll think we should list them, because they are basically anomalies to be cleaned (these patterns show either WIP or changesets that have been in fact abandoned).

The alternatives could lead to worse scenarios:

• If we discard changesets without review but with comments, we will filter those changesets where someone like me came to comment "Hey, can someone review this changeset, please?"
• If we discard changesets with additional uploads from other users, then we may filter significant efforts from a couple of volunteers being ignored by the maintainers.

Let's start with this first 100 issues with no code review.

Just a comment, I've noticed in at least one of the issues, that the information in this list does not match with information in Gerrit.

I've been playing with the ssh command line (as the way we retrieve the data) and this is because the ssh received info is not complete.

Specifically the third on the list: https://gerrit.wikimedia.org/r/#/c/27526 . I get all the information, except the specified Code-Review -1. You can run that command as "ssh -p 29418 gerrit.wikimedia.org gerrit query --patch-sets --all-approvals 27526".

Interesting! Let's fine tune this list.

If there are a few false positives because of some Gerrit problem, I think this is ok. Still those false positives will be probably old changesets needing attention, so it is not too bad.

A list of the (100?) oldest open changesets in gerrit.wikimedia.org without any code review (CR = 0).

OK

It should be sorted by oldest date of last upload.

Now it is sorted by date of first upload.

The view should list the patch title, the related repository, the author, the date of the last upload.

In the final table, the sorting of these fields should be kept (or you can propose a better sorting, but let's align the requirement with the result).

Also, in the final table it would be better to have not the long ugly string for the repo but the human-readable name of the repository linked to the page of such repository in korma (i.e. UploadWizard)

The view should allow to click on each item to get to that changeset in Gerrit.

OK

Working on the last-patchset-upload order.

New 100 gerrit issues. I'm still working on the previous dataset, so there may be new code reviews that were not taken into account for this list.

This is now sorted by the last upload and I've added direct links to Korma and Gerrit.

Hi again,

Please, have a look at http://korma.wmflabs.org/browser/scr-backlog.html . You'll see two options (others can be added later).

A couple of comments:

• I'd like to have this page much more updated that the general dashboard. We can try to have it each 3, 6 or 12 hours. This depends on your needs to have this data updated.
• I still have to polish some minor details (eg: name of the project).

Ok, I think this is fixed. Cllosing the task.