Page MenuHomePhabricator
Create Task
Maniphest T94066

SurfaceWidget should be called TargetWidget
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

It contains a surface, but also a toolbar, debug bar and target config rules.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (edaa19b)mediawiki/extensions/VisualEditormaster+62 -62
[BREAKING CHANGE] Rename SurfaceWidget to TargetWidgetVisualEditor/VisualEditormaster+43 -43
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 26 2015, 7:09 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: VisualEditor, Technical-Debt.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2015, 7:09 PM
Jdforrester-WMF subscribed.Mar 27 2015, 2:45 AM

Should it also be called a VisualTargetWidget with an abstract TargetWidget so we can trivially have WikitextTargetWidget and so on when we start on that in a few weeks'/months' time?

Jdforrester-WMF triaged this task as Medium priority.Mar 27 2015, 2:45 AM
Jdforrester-WMF moved this task from To Triage to Planned Maintenance on the VisualEditor board.
Jdforrester-WMF set Security to None.
Jdforrester-WMF added a project: VisualEditor 2014/15 Q4 blockers.Mar 30 2015, 9:37 PM
Jdforrester-WMF edited a custom field.Apr 1 2015, 7:03 PM
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 15 2015, 6:27 PM
Jdforrester-WMF edited projects, added VisualEditor 2015/16 Q1 blockers; removed VisualEditor 2014/15 Q4 blockers.Jun 16 2015, 10:36 PM
Jdforrester-WMF moved this task from Planned Maintenance to Freezer on the VisualEditor board.Jun 18 2015, 12:18 AM
Jdforrester-WMF added a comment.Jun 30 2015, 9:25 PM

This was discussed at the weekly meeting on 2015-06-30. We decided that it wasn't a priority for this quarter.

Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jun 30 2015, 9:25 PM
Jdforrester-WMF added a subscriber: Mooeypoo.
Esanders added a comment.Jul 18 2015, 9:35 PM

If Target is base-classed then yes, but for now this will be sufficient.

gerritbot subscribed.Jul 18 2015, 9:38 PM

Change 225648 had a related patch set uploaded (by Esanders):
[BREAKING CHANGE] Rename SurfaceWidget to TargetWidget

https://gerrit.wikimedia.org/r/225648

gerritbot added a project: Patch-For-Review.Jul 18 2015, 9:38 PM
gerritbot added a comment.Jul 18 2015, 9:43 PM

Change 225650 had a related patch set uploaded (by Esanders):
[PULL THROUGH] Rename MWSurfaceWidget to MWTargetWidget

https://gerrit.wikimedia.org/r/225650

gerritbot added a comment.Jul 18 2015, 9:56 PM

Change 225648 merged by jenkins-bot:
[BREAKING CHANGE] Rename SurfaceWidget to TargetWidget

https://gerrit.wikimedia.org/r/225648

Esanders mentioned this in rGVED826055ac43ca: [BREAKING CHANGE] Rename SurfaceWidget to TargetWidget.Jul 18 2015, 9:57 PM
Jdforrester-WMF closed this task as Resolved.Jul 18 2015, 10:28 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF edited projects, added VisualEditor 2015/16 Q1 blockers; removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF removed a subscriber: gerritbot.
gerritbot added a comment.Jul 18 2015, 10:30 PM

Change 225650 merged by jenkins-bot:
Update VE core submodule to master (edaa19b)

https://gerrit.wikimedia.org/r/225650

Jdforrester-WMF mentioned this in rEVEDbb46c342556b: Update VE core submodule to master (edaa19b).Jul 18 2015, 10:31 PM
• Forrestbot added a project: WMF-deploy-2015-07-21_(1.26wmf15).Jul 18 2015, 11:00 PM
Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.Jul 18 2015, 11:24 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2015/16 Q1 blockers board.Jul 18 2015, 11:35 PM
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL