Page MenuHomePhabricator

MW-Selenium `on(Page)` yields given block twice
Closed, ResolvedPublic

Description

MW-Selenium 1.0 introduced a custom PageFactory that qualifies relative page-object URLs. Unfortunately, it's current implementation results in the given block being yield twice, resulting in unexpected and sometimes errant behavior. Reproduce with:

Then(/something/) do
  @called = 0
  on(SomePage) { @called += 1 }
  expect(@called) to eq(1)
end

This bug was uncovered while diagnosing issues refactored UploadWizard tests (https://gerrit.wikimedia.org/r/#/c/197975/).

Details

Related Gerrit Patches:
mediawiki/selenium : masterFix double yield bug in `PageFactory#on`

Related Objects

StatusAssignedTask
Resolveddduvall
Resolvedzeljkofilipin
Resolvedzeljkofilipin
Resolvedzeljkofilipin
Resolveddduvall
Resolvedzeljkofilipin
Resolvedhashar
Resolveddduvall
Resolvedzeljkofilipin
Invalidzeljkofilipin
Resolveddduvall
Resolveddduvall
Resolvedzeljkofilipin
Resolvedzeljkofilipin
Resolveddduvall
Resolveddduvall
Invalidzeljkofilipin
Resolvedzeljkofilipin
Resolvedzeljkofilipin
Resolvedzeljkofilipin
Resolvedzeljkofilipin
Resolvedzeljkofilipin
Resolvedzeljkofilipin

Event Timeline

dduvall created this task.Mar 26 2015, 8:06 PM
dduvall claimed this task.
dduvall raised the priority of this task from to High.
dduvall updated the task description. (Show Details)
dduvall added subscribers: dduvall, zeljkofilipin.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2015, 8:06 PM

Change 199987 had a related patch set uploaded (by Dduvall):
Fix double yield bug in PageFactory#on

https://gerrit.wikimedia.org/r/199987

Change 199987 merged by jenkins-bot:
Fix double yield bug in PageFactory#on

https://gerrit.wikimedia.org/r/199987

zeljkofilipin closed this task as Resolved.Mar 26 2015, 8:20 PM
zeljkofilipin set Security to None.