Page MenuHomePhabricator
Create Task
Maniphest T94089

LQT Preview reloads the entire page on preview (since 1.25wmf23)
Closed, ResolvedPublic
Actions

Description

Since today, when writing a reply to a LQT page, if you hit preview, a prompt warns you that you're about to leave the page, which could lead to loss of your pending edits.

I've tried to proceed with the warning, and indeed the page got reloaded with ?action=submit. Hopefully, the page opens the preview on the correct message, and doesn't try to actually edit the whole page.

Until today, hitting preview performed an AJAX communication with the server and displayed the preview without reloading the page.

In fact, once I'm on the preview page (after the page got reloaded), hitting preview again performs the preview in AJAX requests, as it was being done previously.

It can be tested on LiquidThreads Test Page

My guess is that something got broken in 1.25wmf23

Related Objects

Event Timeline

Ciencia_Al_Poder created this task.Mar 26 2015, 8:56 PM
Ciencia_Al_Poder raised the priority of this task from to Needs Triage.
Ciencia_Al_Poder updated the task description. (Show Details)
Ciencia_Al_Poder added projects: MediaWiki-extensions-LiquidThreads, Regression, JavaScript.
Ciencia_Al_Poder subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2015, 8:56 PM
matmarex set Security to None.Mar 26 2015, 9:24 PM
matmarex added a subscriber: TheDJ.
Ciencia_Al_Poder added a subscriber: Krenair.Mar 26 2015, 9:24 PM

I guess it could be caused by rEWED4d54fa44714610f1f451c723d488ccc2cfc2efc6 which would explain why it works after submitting the page, where the URL contains action=submit

TheDJ added a comment.Mar 26 2015, 10:05 PM

Nope, this is https://gerrit.wikimedia.org/r/#/c/198107/

An LQT page does not initially have wpTextbox1...

TheDJ mentioned this in T78709: New improved LivePreview incompatible with ProofreadPage's fancy forms for Index: namespace pages.Mar 26 2015, 10:09 PM
TheDJ mentioned this in rMWe2148c0ac5ac: Revert "mediawiki.action.edit.preview: Disable if there is no #wpTextbox1".Mar 26 2015, 11:26 PM
Krenair assigned this task to TheDJ.Mar 27 2015, 3:51 AM
Krenair added a subscriber: greg.

@TheDJ: Are you planning to put this revert cherry-pick up for SWAT deployment on Monday, when the calendar includes that day?

TheDJ added a comment.EditedMar 27 2015, 7:32 PM

@Krenair, yup.

[edit]
scheduled for Monday now

TheDJ triaged this task as High priority.Mar 28 2015, 12:53 PM
Florian subscribed.Mar 29 2015, 1:06 AM
Fomafix mentioned this in rMWb8c6b41a5017: mediawiki.action.edit.preview: Disable if there is no #wpTextbox1.Mar 29 2015, 3:27 PM
Fomafix subscribed.Mar 29 2015, 5:45 PM
Ciencia_Al_Poder merged a task: T94357: LiquidThreads now asks if I want to leave the page every time I try to preview my comment.Mar 29 2015, 5:56 PM
Ciencia_Al_Poder added a subscriber: He7d3r.
He7d3r renamed this task from LQT Preview reloads the entire page since 1.25wmf23 to LQT Preview reloads the entire page on preview (since 1.25wmf23).Mar 29 2015, 7:13 PM
TheDJ mentioned this in rMW3a95ad3cae2e: Revert "mediawiki.action.edit.preview: Disable if there is no #wpTextbox1".Mar 30 2015, 3:49 PM
TheDJ closed this task as Resolved.Mar 30 2015, 4:46 PM

regression fixed after swat deploy to 1.25wmf23

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL