Page MenuHomePhabricator
Create Task
Maniphest T94113

Page action tutorial should be force closed by clicking the watchstar
Closed, ResolvedPublic
Actions

Description

If you click the watchstar before the tutorial loads this happens:

Screen_Shot_2015-03-26_at_3.49.03_PM.png (406×1 px, 54 KB)

Edge case but looks crappy.

Details

SubjectRepoBranchLines +/-
Prevent tutorial from showing if user clicks watchstar prior to loadmediawiki/extensions/Gathermaster+3 -5
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Mar 26 2015, 10:50 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Gather Sprint Diplodocus, Gather.
Jdlrobson moved this task to Ready for dev on the Gather Sprint Diplodocus board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2015, 10:50 PM
• rmoen claimed this task.Mar 26 2015, 11:28 PM
• rmoen moved this task from Ready for dev to In development on the Gather Sprint Diplodocus board.
• rmoen set Security to None.
gerritbot subscribed.Mar 26 2015, 11:58 PM

Change 200077 had a related patch set uploaded (by Robmoen):
Prevent tutorial from showing if user clicks watchstar prior to load

https://gerrit.wikimedia.org/r/200077

gerritbot added a project: Patch-For-Review.Mar 26 2015, 11:58 PM
• rmoen moved this task from In development to Code review needed on the Gather Sprint Diplodocus board.Mar 26 2015, 11:58 PM
Jdlrobson moved this task from Code review needed to Needs more development (-1) on the Gather Sprint Diplodocus board.Mar 27 2015, 11:28 PM
• Jhernandez edited projects, added Gather Sprint Enwiki; removed Gather Sprint Diplodocus.Mar 30 2015, 10:49 AM
• Jhernandez moved this task from In Analysis to Needs more development (-1) on the Gather Sprint Enwiki board.
Jdlrobson moved this task from Needs triage to In sprint on the Gather board.Mar 30 2015, 4:34 PM
• Moushira subscribed.Mar 30 2015, 5:39 PM
• rmoen moved this task from Needs more development (-1) to Code review needed on the Gather Sprint Enwiki board.Mar 30 2015, 10:33 PM
Jdlrobson merged a task: T94503: two layover overlap on "add".Mar 30 2015, 11:29 PM
Jdlrobson added a subscriber: Yurik.
• Jhernandez subscribed.Apr 1 2015, 11:03 AM

Merged, seems to work fine. Also now it is basically instant, so it is almost impossible to click the watchstar before the CTA appears 👍

• Jhernandez moved this task from Code review needed to Ready for signoff on the Gather Sprint Enwiki board.Apr 1 2015, 11:03 AM
gerritbot added a comment.Apr 1 2015, 11:03 AM

Change 200077 merged by jenkins-bot:
Prevent tutorial from showing if user clicks watchstar prior to load

https://gerrit.wikimedia.org/r/200077

Diffusion mentioned this in rMEXT9ff9a5db611b: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Apr 1 2015, 11:04 AM
• JKatzWMF closed this task as Resolved.Apr 2 2015, 10:23 PM
• JKatzWMF subscribed.

overlay loads so fast I can't really test...either way, issue resolved to satisfaction.

• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Enwiki board.Apr 2 2015, 10:23 PM
• rmoen mentioned this in rEGAT277afc3c25c2: Prevent tutorial from showing if user clicks watchstar prior to load.Apr 8 2015, 6:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL