Page MenuHomePhabricator

QUnit test failing (Check invalid description is evaluated)
Closed, ResolvedPublic

Description

make qunit in MobileFrontend and Special:JavaScriptTest/qunit in browser:

Testing http://localwiki/wiki/Special:JavaScriptTest/qunit?useformat=mobile ...............................................................................................................................................................F.....
>> Gather - Collection description validation
>> Message: Check that an invalid description is correctly evaluated
>> Actual: true
>> Expected: false
>> at http://localwiki/w/resources/lib/qunitjs/qunit.js:1361
>>   at http://localwiki/w/extensions/Gather/tests/qunit/ext.gather.collection.editor/test_CollectionEditOverlay.js:46
>>   at http://localwiki/w/resources/lib/qunitjs/qunit.js:885
>>   at http://localwiki/w/resources/lib/qunitjs/qunit.js:1014
>>   at process (http://localwiki/w/resources/lib/qunitjs/qunit.js:573)
>>   at begin (http://localwiki/w/resources/lib/qunitjs/qunit.js:618)
>>   at http://localwiki/w/resources/lib/qunitjs/qunit.js:634

Event Timeline

Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added a project: Gather.
Florian added subscribers: Florian, Jdlrobson.

Change 200268 had a related patch set uploaded (by Jdlrobson):
Hygiene: Fix js linting, jsdocs and qunit

https://gerrit.wikimedia.org/r/200268

Change 200268 merged by jenkins-bot:
Hygiene: Fix js linting, jsdocs and qunit

https://gerrit.wikimedia.org/r/200268

qunit is now voting \o/

Change 200763 had a related patch set uploaded (by Jdlrobson):
Hygiene: Fix js linting, jsdocs and qunit

https://gerrit.wikimedia.org/r/200763

Change 200764 had a related patch set uploaded (by Jdlrobson):
Hygiene: Fix js linting, jsdocs and qunit

https://gerrit.wikimedia.org/r/200764

Change 200763 merged by MaxSem:
Hygiene: Fix js linting, jsdocs and qunit

https://gerrit.wikimedia.org/r/200763

Change 200764 merged by jenkins-bot:
Hygiene: Fix js linting, jsdocs and qunit

https://gerrit.wikimedia.org/r/200764