Page MenuHomePhabricator
Create Task
Maniphest T94362

Missing label text for Gather special pages
Closed, ResolvedPublic
Actions

Description

I noticed at testwiki that the Special Pages associated with Gather are missing labels in the Special Pages list:

https://test.wikipedia.org/wiki/Special:SpecialPages

They are reported simply as "<gather>" and "<gatherlists>".

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix special page names on Special:SpecialPagesmediawiki/extensions/Gathermaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

Dragons_flight created this task.Mar 29 2015, 7:52 PM
Dragons_flight raised the priority of this task from to Needs Triage.
Dragons_flight updated the task description. (Show Details)
Dragons_flight added a project: Gather.
Dragons_flight subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2015, 7:52 PM
Florian claimed this task.Mar 29 2015, 8:36 PM
gerritbot subscribed.Mar 29 2015, 8:43 PM

Change 200485 had a related patch set uploaded (by Florianschmidtwelzow):
Fix special page names on Special:SpecialPages

https://gerrit.wikimedia.org/r/200485

gerritbot added a project: Patch-For-Review.Mar 29 2015, 8:43 PM
Jdlrobson moved this task from Needs triage to In sprint on the Gather board.Mar 30 2015, 4:32 PM
gerritbot added a comment.Mar 30 2015, 7:05 PM

Change 200485 merged by jenkins-bot:
Fix special page names on Special:SpecialPages

https://gerrit.wikimedia.org/r/200485

Diffusion mentioned this in rMEXTf070d817b188: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Mar 30 2015, 7:05 PM
Florian added subscribers: • bmansurov, Jdlrobson, • Jhernandez.Mar 30 2015, 7:38 PM

@Jdlrobson, @Jhernandez: What do you think about @bmansurov's comment on https://gerrit.wikimedia.org/r/#/c/200485/ ?

Names should be arranged alphabetically.

Jdlrobson added a comment.Mar 30 2015, 11:05 PM

Note there is no convention on message key ordering - it's on a per extension basis. Message keys are handled by Translatewiki anyhow. I remember trying to push for a standard sort order a long time ago but this is the only email on that subject I can find:
https://www.mail-archive.com/mediawiki-i18n@lists.wikimedia.org/msg00655.html

Florian added a comment.Mar 31 2015, 4:30 AM

Oops, i thought @bmansurov means the author names? :/ Maybe he can clarify :)

Jdlrobson added a comment.Mar 31 2015, 5:01 AM

Agai... ordering doesn't really matter. It's just JSON, any client can order it as they wish.

Jdlrobson closed this task as Resolved.Apr 2 2015, 4:02 PM
Jdlrobson moved this task from In sprint to Triaged bugs on the Gather board.
• bmansurov unsubscribed.Apr 2 2015, 6:12 PM
Florian mentioned this in rEGAT9e4a4dc42ad3: Fix special page names on Special:SpecialPages.Apr 8 2015, 6:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits