Page MenuHomePhabricator

Prevent JS breakage on cached pages that refer to _mwq
Closed, DeclinedPublic


On, I noticed references to _mwq in inline script blocks in the HTML. These are the result of rMWe912197b0988, since reverted in rMW2b6eb60ce53c. However, the revert does not seem to take into account the fact that WMF caches HTML for logged-out users for 30 days. The code to "Process the deferred inline script queue" probably needs to be retained for a while to prevent site JavaScript from breaking the moment 1.25wmf23 is deployed to Wikipedias.

Event Timeline

PleaseStand raised the priority of this task from to Needs Triage.
PleaseStand updated the task description. (Show Details)
PleaseStand added subscribers: PleaseStand, ori, Krinkle.

I noticed this too. However it's already been 10 days and it wasn't deployed for more than a few days, so only a small fraction of the Varnish cache contains this right now, and in 20 days it'll have dropped off completely.

The fallback is graceful, it just means there's virtually no javascript execution. It doesn't result in any errors. We've got higher priority / more visible errors in deployment to worry about right now.

Krinkle triaged this task as Lowest priority.Apr 10 2015, 5:19 PM
Krinkle set Security to None.
Krinkle claimed this task.

No longer relevant.