Page MenuHomePhabricator

Trigger an Echo notification after email becomes unverified
Closed, ResolvedPublic

Description

This would be a nice way to alert a user when he is logged in, of the fact that his registered email address is no longer verified. Without a notification, the user will have to visit his Preferences and spot this.

Not everyone dwells inside their prefs, and not everyone keeps the same emailaddress for longer than he is a registered user.

Event Timeline

TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ added a subscriber: TheDJ.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
EBernhardson added a subscriber: EBernhardson.

This should be implemented in BounceHandler (we might write it though). Marking high as echo depends on being able to send emails to notify people.

Change 202735 had a related patch set uploaded (by Tinaj1234):
Trigger Echo notification when registered email address becomes unverified

https://gerrit.wikimedia.org/r/202735

Legoktm on Patch Set 6:

Code-Review-1 (5 comments) On what wiki are global users going to be notified?

I think it would be ideal to send the notification on the wiki where the event triggering the email happened (perhaps delegated to the individual wiki?). Otherwise, extract the username from the "To" field and send to the wiki with most edits.

@Legoktm has 'vaguely' promised to review the patch by this weekend :P

11:40 PM <legoktm> tonythomas: no promises, but I will try to by the end of the week

Change 202735 merged by jenkins-bot:
Trigger Echo notification when registered email address becomes unverified

https://gerrit.wikimedia.org/r/202735

@Legoktm has 'vaguely' promised to review the patch by this weekend :P

11:40 PM <legoktm> tonythomas: no promises, but I will try to by the end of the week

Sorry about the delay :(. Awesome work!

So this gets deployed on Agu 11, 2015 ? Should I create a cherry pic and add it to https://wikitech.wikimedia.org/wiki/Deployments ?

So this gets deployed on Agu 11, 2015 ? Should I create a cherry pic and add it to https://wikitech.wikimedia.org/wiki/Deployments ?

If you want it to go out faster, otherwise you can just let it ride the train, right?

So this gets deployed on Agu 11, 2015 ? Should I create a cherry pic and add it to https://wikitech.wikimedia.org/wiki/Deployments ?

If you want it to go out faster, otherwise you can just let it ride the train, right?

Okey. I will wait till Aug 11. and I meant cherry-pick and not cherry pic :P