Page MenuHomePhabricator

Update wikifont set with new icons
Closed, ResolvedPublic

Description

There are new icons on Dropbox.

What is the best way to consistently check for new icons when the design team adds more to the set?

Event Timeline

violetto raised the priority of this task from to Needs Triage.
violetto updated the task description. (Show Details)

What is the best way to consistently check for new icons when the design team adds more to the set?

You can see all icons currently available in OOjs UI at https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/#icons-mediawiki-vector-ltr (updated every 24 hours).

Which ones are missing? There are 114 files in the Dropbox folder and 128 icons in OOjs UI, which would indicate that you are missing some :)

The set is mixed up with icons from Apex it seems. That might be why there is more than what's on Dropbox.

Is there a way for us to detect what's missing and changes within an icon instead of manually checking them?

The set is mixed up with icons from Apex it seems. That might be why there is more than what's on Dropbox.

Once we have replacements for all the Apex icons (which I think we do), we could get rid of those icons and start using WikiFont icons in the widgets that are currently using them. I'll coordinate with @violetto to remove these.

Is there a way for us to detect what's missing and changes within an icon instead of manually checking them?

There is no way to do this automatically right now because the icons were compressed before being put in OOjs UI. For example—

uniE033- bell.svg (from Dropbox/uncompressed)
<?xml version="1.0" encoding="utf-8"?>
<!-- Generator: Adobe Illustrator 18.1.1, SVG Export Plug-In . SVG Version: 6.00 Build 0)  -->
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
         viewBox="0 0 24 24" enable-background="new 0 0 24 24" xml:space="preserve">
    <path d="M17.5,14V9c0-3-2.3-5-5.5-5S6.5,6,6.5,9v5c0,2,0,3-2,3v1h15v-1C17.5,17,17.5,16,17.5,14z"/>
    <path d="M12,20H9c0,1,1.6,2,3,2s3-1,3-2H12z"/>
</svg>
bell.svg (from OOjs UI/compressed)
<?xml version="1.0" encoding="utf-8"?>
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24">
    <path d="M17.5 14v-5c0-3-2.3-5-5.5-5s-5.5 2-5.5 5v5c0 2 0 3-2 3v1h15v-1c-2 0-2-1-2-3zm-5.5 6h-3c0 1 1.6 2 3 2s3-1 3-2h-3z"/>
</svg>

@TrevorParscal mentioned a few other types of changes too, but I don't recall what they were.
We'll have to make this particular set of changes manually because the files that are in Dropbox and OOjs UI and very different. From next time onwards you could make changes directly in /src/themes/mediawiki/images/icons/ and submit patches to gerrit. I'll walk you through that process.

@TrevorParscal / @matmarex I'm looking to update icons in the set and was wondering what method did you guys use to compress the svg file so I can do the same on my side?

@TrevorParscal / @matmarex I'm looking to update icons in the set and was wondering what method did you guys use to compress the svg file so I can do the same on my side?

@Esanders commented on the patch suggesting you use SVGO. I'll set this up for you soon.

Okay when do you think it will be ready?

Is this a tracking task now?
Now that you can add icons through gerrit directly do you want to close this task?

violetto claimed this task.

Not a tracking task. I can close this task.