Page MenuHomePhabricator
Create Task
Maniphest T94479

Make the comment icon in the toolbar menu match the exclamation mark one used in the surface
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

"Comment" icon appears as a speech bubble icon in the toolbar and in context menus, but inline with context appears as a exclamation point bubble.
This could appear as a warning, instead it should probably appear as a comment.

Needs more investigation

Current:

Screenshot_2015-03-30_13.35.03.png (192×288 px, 14 KB)

Screenshot_2015-03-30_13.41.35.png (104×164 px, 8 KB)

Details

SubjectRepoBranchLines +/-
Comment*: Use the same icon for the CE and UI renderingsVisualEditor/VisualEditormaster+11 -11
Customize query in gerrit

Related Objects

Event Timeline

• KHammerstein created this task.Mar 30 2015, 8:42 PM
• KHammerstein raised the priority of this task from to Needs Triage.
• KHammerstein updated the task description. (Show Details)
• KHammerstein added a project: VisualEditor.
• KHammerstein subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2015, 8:42 PM
Catrope set Security to None.Mar 30 2015, 8:43 PM
Catrope added a subscriber: • TrevorParscal.
• Jaredzimmerman-WMF added a subscriber: Jooojay.Mar 30 2015, 10:30 PM
• Jaredzimmerman-WMF added a project: VisualEditor 2014/15 Q4 blockers.Apr 1 2015, 6:12 PM
Jdforrester-WMF moved this task from Nominated to Backlog on the VisualEditor 2014/15 Q4 blockers board.Apr 1 2015, 6:17 PM
• KHammerstein updated the task description. (Show Details)Apr 1 2015, 6:19 PM
Jdforrester-WMF triaged this task as Medium priority.Apr 1 2015, 6:54 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Apr 7 2015, 4:27 PM
Esanders subscribed.Apr 13 2015, 6:34 PM

Yes - I think when we implemented the user complaint was that VE users were ignoring important comments. Typically on Wikipedia comments are something like: <!-- Please do not fix the spelling of the following name, and here is a huge essay as to why: .... ->, but we should experiment with the appearance and discoverability of these.

Esanders mentioned this in T99024: Improve the design of the visible anchor for hidden HTML comments.May 14 2015, 10:05 AM
Jdforrester-WMF lowered the priority of this task from Medium to Low.Jun 16 2015, 10:32 PM
Jdforrester-WMF edited projects, added VisualEditor 2015/16 Q1 blockers, VisualEditor-EditingTools; removed VisualEditor 2014/15 Q4 blockers.
Jdforrester-WMF moved this task from TR6: Visual diffs to Freezer on the VisualEditor board.Jun 18 2015, 12:35 AM
Jdforrester-WMF renamed this task from Comments icon in toolbar menu and in context don't match to Make the comment icon in the toolbar menu match the exclamation mark one used in the surface.Jul 7 2015, 7:25 PM
Jdforrester-WMF moved this task from Nominated to Backlog: T1 on the VisualEditor 2015/16 Q1 blockers board.
gerritbot subscribed.Jul 10 2015, 10:53 PM

Change 224197 had a related patch set uploaded (by Jforrester):
Comment*: Use the same icon for the CE and UI renderings

https://gerrit.wikimedia.org/r/224197

gerritbot added a project: Patch-For-Review.Jul 10 2015, 10:53 PM
Jdforrester-WMF moved this task from Freezer to TR1: Releases on the VisualEditor board.Jul 21 2015, 6:16 PM
Jdforrester-WMF removed a project: VisualEditor 2015/16 Q1 blockers.Jul 21 2015, 6:29 PM
gerritbot added a comment.Jul 22 2015, 10:19 PM

Change 224197 merged by jenkins-bot:
Comment*: Use the same icon for the CE and UI renderings

https://gerrit.wikimedia.org/r/224197

Jdforrester-WMF mentioned this in rGVED71c65537cc89: Comment*: Use the same icon for the CE and UI renderings.Jul 22 2015, 10:19 PM
Jdforrester-WMF closed this task as Resolved.Jul 22 2015, 10:19 PM
Jdforrester-WMF assigned this task to Jdforrester-PERSONAL.
Jdforrester-WMF edited projects, added WMF-deploy-2015-07-28_(1.26wmf16); removed Patch-For-Review.
Ryasmeen added a project: Verified-in-Phase0.Jul 29 2015, 4:33 AM
Ryasmeen added a project: Verified-in-Phase2.Jul 30 2015, 11:27 PM
Jooojay added a comment.Aug 21 2015, 5:12 AM

It is unclear to me what is happening here since there are no notes? It says "resolved" and then it says moved to some other place? Can you please clarify?

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL