Page MenuHomePhabricator
Create Task
Maniphest T94506

BUG: Catalan donate flow is not retaining language data
Closed, ResolvedPublic
Actions

Description

We've received a couple complaints from Catalan donors saying they got their TY in English when they donated through the Catalan Wikipedia. I thought it was simply donor error, but after we heard from about 5 donors, I tested the flow.

I donated through the donate.wikimedia.org/wiki/Special:FundraiserLandingPage?uselang=ca&country=ES page and the flow was mostly in Catalan, but I got to an English TY page and an English TY letter. Civi has my preferred language as "unknown" for this donation (see: https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=10907250).

It would be great if we could fix this ASAP so our list for emails next year is as correct as possible, and so we thank caES donors in the correct language.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DonationInterfacemaster+29 -11Be much more conservative about unstaging
mediawiki/extensions/DonationInterfacemaster+36 -5Fix unstaging issue
mediawiki/extensions/DonationInterfacemaster+26 -10Don't overwrite donor language with fallback value
Customize query in gerrit

Related Objects
Search...

Event Timeline

• CCogdill_WMF created this task.Mar 30 2015, 11:34 PM
• CCogdill_WMF raised the priority of this task from to High.
• CCogdill_WMF updated the task description. (Show Details)
• CCogdill_WMF added a project: Fundraising-Backlog.
• CCogdill_WMF added subscribers: • CCogdill_WMF, • atgo, Pcoombe and 2 others.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2015, 11:34 PM
• atgo raised the priority of this task from High to Unbreak Now!.Mar 31 2015, 6:19 PM
• atgo added a project: Fundraising Sprint Grandmaster Flash.
• atgo lowered the priority of this task from Unbreak Now! to High.Mar 31 2015, 6:23 PM
• atgo edited projects, added Fundraising Sprint House of Pain; removed Fundraising Sprint Grandmaster Flash.
• atgo set Security to None.
• CCogdill_WMF added a comment.Mar 31 2015, 6:42 PM

Update: tested this in Spanish as well and it does not seem to be a problem
there. This may be isolated to Catalan only.

• CCogdill_WMF mentioned this in T94604: BUG: Language error in "Transaction could not be accepted" page.Mar 31 2015, 7:12 PM
• atgo added a project: Fundraising Sprint Grandmaster Flash.Mar 31 2015, 8:19 PM

@CCogdill_WMF were these all credit card donors?

• atgo renamed this task from Catalan donate flow is not retaining language data to BUG: Catalan donate flow is not retaining language data.Mar 31 2015, 8:21 PM
awight claimed this task.Mar 31 2015, 8:57 PM
awight moved this task from Backlog to Doing on the Fundraising Sprint Grandmaster Flash board.
• CCogdill_WMF added a comment.Mar 31 2015, 9:04 PM

@atgo yes, all the reports we've gotten have been from GC donors.

awight added a comment.Mar 31 2015, 11:13 PM

The problem is in DonationInterface's GlobalCollect module. We're normalizing the language down to what the processor supports (globalcollect_gateway/globalcollect.adapter.php::getAvailableLanguages).

That's fair enough for contacting the gateway, but then we store the normalized language in the contribution_tracking table, so when we restore the workflow at the Thank You page, the language is incorrect cos it's loaded from the database.

awight added a comment.Apr 1 2015, 12:06 AM

Have to set this down for a minute. The offending contribution_tracking update statement is just before the SET_PAYMENT call.

gerritbot added a subscriber: gerritbot.Apr 1 2015, 6:28 AM

Change 201132 had a related patch set uploaded (by Awight):
Don't overwrite donor language with fallback value

https://gerrit.wikimedia.org/r/201132

gerritbot added a project: Patch-For-Review.Apr 1 2015, 6:28 AM
awight moved this task from Doing to Review on the Fundraising Sprint Grandmaster Flash board.Apr 1 2015, 7:26 AM
awight added a comment.EditedApr 1 2015, 7:30 AM

I think the attached patch will fix this. Please note,

  • This issue affected donors making GlobalCollect transactions, whose preferred language was not in GlobalCollect's list of approved translations, linked above.
  • The correct donor language information is still available in logs for the last month, and I believe the problem began with the Mar 12th deployment. I would be happy to spelunk if this is helpful?
awight mentioned this in T94670: Backfill donor language information from logs?.Apr 1 2015, 7:46 AM
• atgo added a comment.Apr 1 2015, 5:12 PM

@awight yes, a little spelunking would be awesome at least to determine the scope. Thanks!

• atgo moved this task from Backlog to Review on the Fundraising Sprint House of Pain board.Apr 1 2015, 5:58 PM
• CCogdill_WMF added a comment.Apr 1 2015, 6:56 PM

@Jessica @MeganHernandez_WMF looks like these upcoming languages aren't on the GC list:

  • Latvian (lv)
  • Ukrainian (uk)
  • Possibly Slovakian (sk) - GC list says "Slovene"

I think Ukraine is the only larger one, and even it is a list of only 15k past donors in en, ru, and uk.

• atgo added a comment.Apr 1 2015, 7:55 PM

We expect to have this resolved before those campaigns :)

• CCogdill_WMF added a comment.Apr 1 2015, 7:57 PM

Ah okay @atgo, nevermind then!

gerritbot added a comment.Apr 1 2015, 10:34 PM

Change 201132 merged by jenkins-bot:
Don't overwrite donor language with fallback value

https://gerrit.wikimedia.org/r/201132

awight mentioned this in rMEXT69c23b690672: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Apr 1 2015, 10:34 PM
awight mentioned this in rEDOI04f4317bb50b: Don't overwrite donor language with fallback value.Apr 1 2015, 10:50 PM
awight moved this task from Review to Doing on the Fundraising Sprint Grandmaster Flash board.Apr 1 2015, 11:39 PM
gerritbot added a comment.Apr 1 2015, 11:39 PM

Change 201382 had a related patch set uploaded (by Awight):
WIP Fix unstaging issue

https://gerrit.wikimedia.org/r/201382

gerritbot added a comment.Apr 9 2015, 12:09 AM

Change 201382 merged by jenkins-bot:
Fix unstaging issue

https://gerrit.wikimedia.org/r/201382

awight moved this task from Review to Pending Deployment on the Fundraising Sprint House of Pain board.Apr 9 2015, 12:09 AM
awight mentioned this in rEDOIcb0a079f6f34: Fix unstaging issue.Apr 9 2015, 12:10 AM
awight mentioned this in rMEXT8604352d0ddf: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….
awight added a parent task: T94670: Backfill donor language information from logs?.Apr 12 2015, 2:16 AM
Ejegg added a project: Fundraising Sprint Indigo Girls.Apr 15 2015, 10:22 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Indigo Girls board.
awight moved this task from Pending Deployment to Doing on the Fundraising Sprint Indigo Girls board.Apr 20 2015, 7:19 PM

Deployed patches made no difference!

gerritbot added a comment.Apr 22 2015, 6:28 PM

Change 205898 had a related patch set uploaded (by Awight):
Be much more conservative about unstaging

https://gerrit.wikimedia.org/r/205898

awight moved this task from Doing to Review on the Fundraising Sprint Indigo Girls board.Apr 22 2015, 6:28 PM
gerritbot added a comment.Apr 23 2015, 3:58 PM

Change 205898 merged by jenkins-bot:
Be much more conservative about unstaging

https://gerrit.wikimedia.org/r/205898

awight mentioned this in rMEXTf59bcbfcf849: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Apr 23 2015, 3:58 PM
awight mentioned this in rEDOIada4a1b73f64: Be much more conservative about unstaging.
awight closed this task as Resolved.Apr 24 2015, 4:50 PM
awight moved this task from Review to Done on the Fundraising Sprint Indigo Girls board.
DStrine moved this task from Triage to Closed Sprint Work Q3 1415 on the Fundraising-Backlog board.Jun 25 2015, 4:38 PM
• atgo moved this task from Closed Sprint Work Q3 1415 to Closed Sprint Work Q4 1415 on the Fundraising-Backlog board.Jun 30 2015, 10:28 PM
DStrine edited projects, added Fr-tech-archived-from-FY-2014/15; removed Fundraising-Backlog.Jan 11 2018, 9:35 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL