Page MenuHomePhabricator
Create Task
Maniphest T94550

UploadWizard throws error when navigating away from file step
Closed, ResolvedPublic
Actions

Description

Steps to repro:

Stack trace in debug mode:

Uncaught TypeError: Cannot read property 'length' of undefined
uw.controller.Step.js:290 SP.isComplete
mw.UploadWizard.js:417 (anonymous function)
load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150330T23…:392 Query.extend.each
mw.UploadWizard.js:416 mw.UploadWizard.isComplete
mw.UploadWizard.js:81 mw.UploadWizard.allowCloseWindow.mw.confirmCloseWindow.test
mediawiki.confirmCloseWindow.js:40 (anonymous function)
load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150330T23…:4665 jQuery.event.dispatch
load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150330T23…:4333 jQuery.event.add.elemData.handle

Given this only happens on unload, probably harmless.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Backport UploadWizard bugfixmediawiki/corewmf/1.25wmf24+1 -1
Fix JS error happening when navigating away while on file stepmediawiki/extensions/UploadWizardwmf/1.25wmf24+1 -1
Fix JS error happening when navigating away while on file stepmediawiki/extensions/UploadWizardmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tgr created this task.Mar 31 2015, 9:59 AM
• Tgr raised the priority of this task from to Lowest.
• Tgr updated the task description. (Show Details)
• Tgr added a project: UploadWizard.
• Tgr subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptMar 31 2015, 9:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Gilles added subscribers: • Gilles, MarkTraceur.Apr 1 2015, 9:23 AM

This is coming from recently merged code, probably a trivial fix.

• Tgr claimed this task.Apr 1 2015, 11:53 AM
• Tgr raised the priority of this task from Lowest to Medium.

Should be fixed + backported before error logging is deployed, otherwise we'll get a bunch of false positives.

• Gilles claimed this task.Apr 1 2015, 12:44 PM
gerritbot subscribed.Apr 1 2015, 12:47 PM

Change 201179 had a related patch set uploaded (by Gilles):
Fix JS error happening when navigating away while on file step

https://gerrit.wikimedia.org/r/201179

gerritbot added a project: Patch-For-Review.Apr 1 2015, 12:47 PM
gerritbot added a comment.Apr 3 2015, 3:05 PM

Change 201179 merged by jenkins-bot:
Fix JS error happening when navigating away while on file step

https://gerrit.wikimedia.org/r/201179

Diffusion mentioned this in rMEXTda020f324bdc: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Apr 3 2015, 3:05 PM
• Gilles mentioned this in rEUWIcb9480fee92c: Fix JS error happening when navigating away while on file step.Apr 3 2015, 3:07 PM
gerritbot added a comment.Apr 5 2015, 11:08 AM

Change 201937 had a related patch set uploaded (by Gilles):
Fix JS error happening when navigating away while on file step

https://gerrit.wikimedia.org/r/201937

gerritbot added a comment.Apr 5 2015, 11:13 AM

Change 201937 merged by jenkins-bot:
Fix JS error happening when navigating away while on file step

https://gerrit.wikimedia.org/r/201937

• Gilles mentioned this in rEUWIf2f2d9372333: Fix JS error happening when navigating away while on file step.Apr 5 2015, 11:13 AM
gerritbot added a comment.Apr 5 2015, 11:52 AM

Change 201941 had a related patch set uploaded (by Gilles):
Backport UploadWizard bugfix

https://gerrit.wikimedia.org/r/201941

gerritbot added a comment.Apr 6 2015, 3:46 PM

Change 201941 merged by Anomie:
Backport UploadWizard bugfix

https://gerrit.wikimedia.org/r/201941

• Gilles mentioned this in rMW58ef70005c0f: Backport UploadWizard bugfix.Apr 6 2015, 3:46 PM
MarkTraceur added a parent task: T96907: Clean up possible refactor-related regressions.Apr 22 2015, 8:13 PM
• Tgr closed this task as Resolved.Apr 22 2015, 8:16 PM

Gilles fixed this a while ago, I just forgot to close it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits