Page MenuHomePhabricator
Create Task
Maniphest T94568

SpamBlacklist branch REL1_23 breaks unit test
Closed, ResolvedPublic
Actions

Description

core 1.23 with SpamBlacklist using REL1_23, unit tests die with,

.........................................SSSSSS.....PHP Catchable fatal error: Argument 1 passed to WikitextContent::getParserOutput() must be an instance of Title, null given, called in /srv/www/htdocs/mwgit123/extensions/SpamBlacklist/SpamBlacklistHooks.php on line 28 and defined in /srv/www/htdocs/mwgit123/includes/content/WikitextContent.php on line 313

Details

SubjectRepoBranchLines +/-
(DO NOT SUBMIT) test REL1_23 CImediawiki/extensions/SpamBlacklistREL1_23+0 -0
(DO NOT SUBMIT) test REL1_23 CImediawiki/extensions/SpamBlacklistmaster+0 -0
Customize query in gerrit

Event Timeline

• csteipp created this task.Mar 31 2015, 2:21 PM
• csteipp raised the priority of this task from to Needs Triage.
• csteipp updated the task description. (Show Details)
• csteipp added a project: Release-Engineering-Team.
• csteipp subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 31 2015, 2:21 PM
Aklapper triaged this task as Medium priority.Apr 1 2015, 12:05 PM
Aklapper added a project: SpamBlacklist.
Aklapper set Security to None.
gerritbot subscribed.May 29 2015, 10:38 AM

Change 214589 had a related patch set uploaded (by Hashar):
(DO NOT SUBMIT) test REL1_23 CI

https://gerrit.wikimedia.org/r/214589

gerritbot added a project: Patch-For-Review.May 29 2015, 10:38 AM
gerritbot added a comment.May 29 2015, 10:41 AM

Change 214589 abandoned by Hashar:
(DO NOT SUBMIT) test REL1_23 CI

Reason:
was meant for REL1_23 branch

https://gerrit.wikimedia.org/r/214589

gerritbot added a comment.May 29 2015, 10:41 AM

Change 214590 had a related patch set uploaded (by Hashar):
(DO NOT SUBMIT) test REL1_23 CI

https://gerrit.wikimedia.org/r/214590

gerritbot added a comment.May 29 2015, 10:47 AM

Change 214590 abandoned by Hashar:
(DO NOT SUBMIT) test REL1_23 CI

https://gerrit.wikimedia.org/r/214590

hashar closed this task as Resolved.May 29 2015, 10:49 AM
hashar claimed this task.
hashar subscribed.

I sent a dummy change https://gerrit.wikimedia.org/r/#/c/214590/

And it pass mwext-SpamBlacklist-testextension-zend

Assuming whatever was broken got fixed somehow.

greg moved this task from INBOX to Done on the Release-Engineering-Team board.Jun 5 2015, 3:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL