Page MenuHomePhabricator

Jobs in the jobqueue should have their context's IP address set to the initiating request's IP by default
Open, LowPublic

Description

@Jalexander mentioned that there are a lot of log entries on meta that have 127.0.0.1 as their CU IP address, instead of the IP of the user who initiated the job (most or all of the entries are from work that comes from jobs, which use localhost by default).

James would prefer we default to setting up the context based on the request that created the job. Jobs where we're not doing things that log CU data can specifically exclude passing the context to save the overhead, if it's significant.

Event Timeline

csteipp raised the priority of this task from to Needs Triage.
csteipp updated the task description. (Show Details)
csteipp added subscribers: csteipp, Jalexander, aaron.

As a default that seems like "a fractal of a bad design". But we surely should fix any page editing (message/translate) jobs that are not doing this atm.

KineticPelagic subscribed.

As part of my Clinic Duty rotation, I am moving this task to the Bugs & Chores column, with priority of Low because:

  • According to https://www.mediawiki.org/wiki/Developers/Maintainers, the MWI team stewards JobQueue.
  • The task description mentions this issue as affecting "a lot of log entries", though I am unclear how accurate this statement has remained since 2015.
  • Our team member Aaron advocated to make a fix.
  • Regarding effort, discovery has to be done as to the approach for a fix, for example to research how to set up context, how to accurately identify which request created a job, what CU data means, how to definitively determine whether a job is "doing things that log CU data", and if the overhead to pass context is "significant" enough to warrant exclusion of context passing in certain cases.
  • I am not sure that the people most invested in this task will be available to answer questions because the author's account is disabled and the most recent activity of the individual whom the task description mentions was over nine months ago.