Page MenuHomePhabricator
Create Task
Maniphest T94676

There should be no switch buttons if the editor being switched to isn't supported
Closed, ResolvedPublic
Actions

Description

VE depends on a couple of things:

  • user option 'visualeditor-enable' should be true (= enabled in beta features, or default preference)
  • ES5 support
  • SVG support

mw.org has visualeditor-enable enabled by default, but I guess users can opt-out. On enwiki, it seems to be disabled by default, I'm getting a false as anon.

Details

SubjectRepoBranchLines +/-
Conditionally add switch buttonsmediawiki/extensions/Flowwmf/1.25wmf24+73 -61
Conditionally add switch buttonsmediawiki/extensions/Flowmaster+73 -61
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Apr 1 2015, 9:47 AM
matthiasmullie raised the priority of this task from to Needs Triage.
matthiasmullie updated the task description. (Show Details)
matthiasmullie added projects: StructuredDiscussions, Collaboration-Team-Triage.
matthiasmullie subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2015, 9:47 AM
gerritbot subscribed.Apr 1 2015, 9:49 AM

Change 201153 had a related patch set uploaded (by Matthias Mullie):
Conditionally add switch buttons

https://gerrit.wikimedia.org/r/201153

gerritbot added a project: Patch-For-Review.Apr 1 2015, 9:49 AM
gerritbot added a comment.Apr 1 2015, 8:48 PM

Change 201153 merged by jenkins-bot:
Conditionally add switch buttons

https://gerrit.wikimedia.org/r/201153

EBernhardson mentioned this in rEFLW3e0cbc544e82: Conditionally add switch buttons.Apr 1 2015, 8:49 PM
Diffusion mentioned this in rMEXTc1e478688fc2: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Apr 1 2015, 8:49 PM
gerritbot added a comment.Apr 1 2015, 9:48 PM

Change 201358 had a related patch set uploaded (by EBernhardson):
Conditionally add switch buttons

https://gerrit.wikimedia.org/r/201358

gerritbot added a comment.Apr 1 2015, 9:53 PM

Change 201358 merged by jenkins-bot:
Conditionally add switch buttons

https://gerrit.wikimedia.org/r/201358

EBernhardson mentioned this in rEFLW1ee6d961d7e7: Conditionally add switch buttons.Apr 1 2015, 9:54 PM
Catrope closed this task as Resolved.Apr 24 2015, 5:52 PM
Catrope assigned this task to matthiasmullie.
Catrope subscribed.
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Apr 27 2015, 5:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL