Page MenuHomePhabricator
Create Task
Maniphest T94683

references to Bugzilla in pywikibot
Closed, ResolvedPublic
Actions

Description

Bugzilla has been replaced by Phabricator, and references in the codebase need to be updated. misspelling even recommends that users create bugs in Bugzilla.

$ git grep -i bugzilla
pywikibot/data/api.py: # Bugzilla 49978
pywikibot/families/wikibooks_family.py: 'co': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=28644
pywikibot/families/wikibooks_family.py: 'kn': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=20325
pywikibot/families/wikibooks_family.py: 'sw': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=25170
pywikibot/families/wikibooks_family.py: 'vo': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=37413
pywikibot/families/wikibooks_family.py: 'za': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=20325
pywikibot/families/wikibooks_family.py: 'zu': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=25425
pywikibot/families/wikinews_family.py: 'hu': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=28342
pywikibot/families/wikinews_family.py: 'nl': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=20325
pywikibot/families/wikinews_family.py: 'th': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=28341
pywikibot/families/wikiquote_family.py: 'ang': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=29150
pywikibot/families/wikiquote_family.py: 'ast': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=28964
pywikibot/families/wikiquote_family.py: 'kk': None, # https://bugzilla.wikimedia.org/show_bug.cgi?id=20325
pywikibot/family.py: 'bugzilla': 'bugzilla',
pywikibot/logentries.py: # ( https://bugzilla.wikimedia.org/show_bug.cgi?id=17781 )
pywikibot/site.py: # bug: see https://bugzilla.wikimedia.org/show_bug.cgi?id=7304
pywikibot/site.py: # https://bugzilla.wikimedia.org/show_bug.cgi?id=53894
scripts/cosmetic_changes.py: 39, # Single quotation mark (") - Bugzilla 24093
scripts/misspelling.py: https://bugzilla.wikimedia.org/enter_bug.cgi?product=Pywikibot
tests/link_tests.py: link = Link('bugzilla:1337', source=self.site)
tests/link_tests.py: 'bugzilla:1337 is not a local page on wikipedia:en, and the '
tests/link_tests.py: 'interwiki prefix bugzilla is not supported by PyWikiBot!',

Also these phab tasks need to be reviewed to ensure that no vital information was lost in the migration.

Details

ProjectBranchLines +/-Subject
pywikibot/coremaster+31 -36Replacing references from Bugzilla to Phabricator
Customize query in gerrit

Event Timeline

jayvdb created this task.Apr 1 2015, 11:05 AM
jayvdb raised the priority of this task from to Needs Triage.
jayvdb updated the task description. (Show Details)
jayvdb added projects: Pywikibot, Phabricator.
jayvdb added a subscriber: jayvdb.
Restricted Application added subscribers: Aklapper, Unknown Object (MLST). · View Herald TranscriptApr 1 2015, 11:05 AM
XZise added a subscriber: XZise.Apr 1 2015, 11:36 AM

By the way:

git grep -iE 'bug *[1-9]'
pwb.py:    # Use env var to communicate to config2.py pwb.py location (bug 72918).
pywikibot/data/api.py:        # bug 66619, after gerrit 124323 breaking change we have a
pywikibot/data/api.py:                retry = class_name in ['DBConnectionError',  # bug 62974
pywikibot/data/api.py:                                       'DBQueryError',  # bug 58158
pywikibot/data/api.py:                                       'ReadOnlyError'  # bug 59227
pywikibot/data/api.py:                        # only "(query-)continue" returned. See Bug 72209.
pywikibot/exceptions.py:    This is considered invalid in Pywikibot. See Bug 73184.
pywikibot/login.py:            # TODO: investigate other unhandled API codes (bug 73539)
pywikibot/page.py:            self._pageprops = {}  # page may not have pageprops (see bug 54868)
pywikibot/page.py:        # FIXME: bug 73561: withSortKey is ignored by Site.pagecategories
pywikibot/page.py:                if 'removed' not in self._content['labels'][lang]:  # Bug 54767
pywikibot/pagegenerators.py:            # partial workaround for bug 67249
pywikibot/site.py:            page._isredir = False  # bug 54684
pywikibot/site.py:            # TODO: Dummy value to allow also Unicode names, see bug 73661
pywikibot/textlib.py:            # month and day format might be identical (e.g. see bug 69315),
scripts/blockpageschecker.py:        # (see bug 55322)
scripts/cosmetic_changes.py:                    # bug 55242 should be implemented
scripts/cosmetic_changes.py:        # deactivated due to bug 55185
scripts/reflinks.py:                    u = linkedpagetext.decode(enc[0])   # Bug 67410
scripts/unusedfiles.py:                pywikibot.output(u"File '%s' does not exist (see bug 69133)."
setup.py:    # See bug 66010, Windows users will have issues
tests/archivebot_tests.py:        if code != 'de':  # bug 67663
tests/http_tests.py:    @expected_failure_if(sys.version_info[0] > 2)  # bug 72236
tests/script_tests.py:    'makecat',      # bug 69781
tests/script_tests.py:    'editarticle': 'Nothing changed',  # This masks related bug 68645 but that
tests/script_tests.py:    'transferbot': 'Target site not different from source site',  # Bug 68662
tests/script_tests.py:            # TODO: after bug 68611 and 68664 (and makecat), split -help
tests/script_tests.py:                               'checkimages',     # bug 68613
tests/site_tests.py:                      'searched. See also bug 73120'.format(using))
Qgil removed a project: Phabricator.Apr 7 2015, 1:17 PM
Qgil set Security to None.
Aklapper added a project: good first task.Apr 7 2015, 1:26 PM

The full URLs are redirects anyway. For those plain text "Bug 123456" links, turn them into Phab task URLs by adding 2000 to the number so you get the corresponding Phabricator task number? :)

(PS: Please feel free to set the good first task project for trivial tasks.)

mgrabovsky added a subscriber: mgrabovsky.May 23 2015, 7:13 PM
MarcoAurelio claimed this task.Aug 29 2015, 2:48 PM
MarcoAurelio added a subscriber: MarcoAurelio.

If it's just modifying the text, I'm willing to take a shot at this one. However it seems that many files should be changed. Shall I submit a patch for every change or a unified gerrit patch?

MarcoAurelio triaged this task as Low priority.Aug 29 2015, 2:50 PM

Lowering priority since this is not breaking the code and does not seem to be urgent. Working on it, I hope to come with a patch shortly or in the next days.

Mpaa added a subscriber: Mpaa.Aug 29 2015, 2:59 PM
In T94683#1586823, @MarcoAurelio wrote:

Lowering priority since this is not breaking the code and does not seem to be urgent. Working on it, I hope to come with a patch shortly or in the next days.

I suggest a unified gerrit patch.

gerritbot added a subscriber: gerritbot.Aug 29 2015, 4:15 PM

Change 234734 had a related patch set uploaded (by MarcoAurelio):
WIP: Replacing old Bugzilla tickets with Phab.

https://gerrit.wikimedia.org/r/234734

gerritbot added a project: Patch-For-Review.Aug 29 2015, 4:15 PM
gerritbot added a comment.Aug 30 2015, 11:57 AM

Change 234847 had a related patch set uploaded (by MarcoAurelio):
Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/pywikibot/core into review/marcoaurelio/T94683

https://gerrit.wikimedia.org/r/234847

gerritbot added a comment.Aug 30 2015, 11:59 AM

Change 234847 abandoned by MarcoAurelio:
Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/pywikibot/core into review/marcoaurelio/T94683

Reason:
Patch amend fail. This was to amend I413e4c7bbd2f961f108fa9dfbb6cf90b03be4ec2 Something went wrong.

https://gerrit.wikimedia.org/r/234847

MarcoAurelio added a comment.Aug 30 2015, 1:54 PM

I messed up and couldn't properly modify the gerrit patch I submitted. I'll try again. Sorry.

gerritbot added a comment.Aug 30 2015, 2:25 PM

Change 234734 abandoned by MarcoAurelio:
Replacing references from Bugzilla to Phabricator

https://gerrit.wikimedia.org/r/234734

MarcoAurelio removed MarcoAurelio as the assignee of this task.Aug 31 2015, 1:25 PM
MarcoAurelio raised the priority of this task from Low to Needs Triage.
MarcoAurelio claimed this task.Sep 24 2015, 9:08 AM

Will retry.

MarcoAurelio triaged this task as Low priority.Sep 24 2015, 9:08 AM
MarcoAurelio removed a project: Patch-For-Review.
MarcoAurelio removed MarcoAurelio as the assignee of this task.Nov 14 2015, 6:34 PM
mgrabovsky removed a subscriber: mgrabovsky.Nov 14 2015, 9:24 PM
Nemo_bis added a project: Google-Code-In-2015.Jan 7 2016, 9:02 PM
Nemo_bis moved this task from Proposed to Mentors Required on the Google-Code-In-2015 board.Jan 9 2016, 9:57 AM
8ohit.dua added a subscriber: 8ohit.dua.Jan 9 2016, 8:09 PM

https://codein.withgoogle.com/dashboard/tasks/5998186497835008/

8ohit.dua moved this task from Mentors Required to Imported into GCI site on the Google-Code-In-2015 board.Jan 9 2016, 8:09 PM
gerritbot added a comment.Jan 10 2016, 12:07 PM

Change 234734 restored by John Vandenberg:
Replacing references from Bugzilla to Phabricator

Reason:
I'll polish this up

https://gerrit.wikimedia.org/r/234734

jayvdb added a subscriber: Nemo_bis.Jan 10 2016, 1:43 PM
In T94683#1922857, @8ohit.dua wrote:

https://codein.withgoogle.com/dashboard/tasks/5998186497835008/

We already had a patch for this, which is why I didnt create a GCI task for it. While it was abandoned, it was largely correct and appropriate, and only needed a little polish which I've been meaning to do for a while. I've now rebased and polished it.
@8ohit.dua, it would be helpful if you did a review of that patch anyway, since you're listed as a mentor on other tasks.
@Nemo_bis, could you cancel that GCI task to avoid confusion.

gerritbot added a comment.Jan 10 2016, 2:32 PM

Change 234734 merged by jenkins-bot:
Replacing references from Bugzilla to Phabricator

https://gerrit.wikimedia.org/r/234734

jayvdb closed this task as Resolved.Jan 10 2016, 10:24 PM
jayvdb assigned this task to MarcoAurelio.
jayvdb removed a project: Google-Code-In-2015.
Nemo_bis added a comment.Jan 11 2016, 7:47 AM

Done. I was confused by the removal of the Patch-For-Review project in T94683#1669937. We should probably document that it's especially important to keep the project when a patch was abandoned, as the tag is the only way to know there is something left lingering which can be built upon.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMar 27 2017, 3:34 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL