Page MenuHomePhabricator

Must be able to combine ResourceLoaderImageModule's icon CSS and regular CSS files in one module
Closed, DeclinedPublic

Description

We must be able to combine ResourceLoaderImageModule's icon CSS and regular CSS files in one module. Otherwise we can't use ResourceLoaderImageModule to ship OOjs UI's "core" icons, indicators and textures (which have to be included in the 'oojs-ui.styles' module).

Since we can't do dependencies for CSS-only modules (T63577), the only way is probably to make ResourceLoaderImageModule inherit from ResourceLoaderFileModule.

Event Timeline

matmarex created this task.Apr 1 2015, 7:03 PM
matmarex claimed this task.
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 1 2015, 7:03 PM
Jdforrester-WMF triaged this task as Normal priority.Apr 1 2015, 7:17 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Change 201266 had a related patch set uploaded (by Bartosz Dziewoński):
ResourceLoaderImageModule: Inherit from ResourceLoaderFileModule

https://gerrit.wikimedia.org/r/201266

matmarex closed this task as Declined.Apr 2 2015, 4:52 PM

Actually, this won't help for this use case, we will have to split 'oojs-ui.styles' either way. The patch above might be useful on its own (or not), but this bug is definitely not.

matmarex edited a custom field.Apr 2 2015, 6:10 PM