Page MenuHomePhabricator

Rewrite Special:CheckUser using server side templates
Closed, ResolvedPublic

Description

This would really improve the readability of the code...

See https://www.mediawiki.org/wiki/Manual:HTML_templates for documentation on how to use server-side HTML templates in MediaWiki.

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: CheckUser.
Jdlrobson added subscribers: Jdlrobson, kaldari.

@AronManning Can you provide more context on this ticket? I'm not sure what's being requested and why.

@Niharika - This is just a code maintenance issue. No user-facing features would actually be affected by this (although it might make it easier to build such features).

Change 814376 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use Mustache templates on the server side for result lines in CheckUser

https://gerrit.wikimedia.org/r/814376

Claiming as I've written a patch for this.

@Dreamy_Jazz have you identified a code reviewer for this one? Seems platform engineering are maintainers here so tagging accordingly.

@Jdlrobson I've not identified a reviewer for this. Thanks for tagging the relevant team. I haven't been able to see if there is any tests for mustache templates, so if there is I would appreciate it being enabled on CheckUser if it isn't already.

It's coming up to a month since I uploaded a patch. Is there anything I may have missed with this patch that needs to be addressed?

Change 814376 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use Mustache templates on the server side for result lines in CheckUser

https://gerrit.wikimedia.org/r/814376

Merged. Will be in the next train.