Page MenuHomePhabricator

Implement the mock up in T94736
Closed, ResolvedPublic5 Estimated Story Points

Description

  • Use fake data to populate the interface mocked in T94736
  • Note that we will want to build this so we can potentially change the design around

tags-06.png (1×641 px, 109 KB)

Event Timeline

JKatzWMF raised the priority of this task from to Needs Triage.
JKatzWMF updated the task description. (Show Details)
JKatzWMF added a subscriber: JKatzWMF.
phuedx renamed this task from Place category tags on pages that have been identified as having that property, according to mock up in T94736 to Implement the mock up in T94736.Apr 1 2015, 8:38 PM
phuedx updated the task description. (Show Details)
phuedx set Security to None.
KLans_WMF renamed this task from Implement the mock up in T94736 to (3) Implement the mock up in T94736.Apr 1 2015, 8:40 PM
KLans_WMF renamed this task from (3) Implement the mock up in T94736 to Implement the mock up in T94736.Apr 10 2015, 7:49 PM
KLans_WMF edited a custom field.

@JKatzWMF: Rather than putting this behind a feature flag should we just develop this in alpha and beta?

@JKatzWMF: I went ahead and implemented it as a beta feature.

@phuedx, great!
Do you need a list of tags? The desired display is slightly different than the category name in some places.

Category:National Basketball Association All-Stars--> NBA All Stars
Category:20th-century American politicians--> American Politicians
Category:Object-oriented programming languages--> Object-Oriented Programming Languages
Category:Western Europe--> European States
Category:American female pop singers-->American Female Pop Singers
Category:American drama television series --> American drama TV series
Category:Modern painters --->Modern Painters
Category:Landmarks in San Francisco, California--> Landmarks in San Francisco, California

@KHammerstein do you need to make a mock that shows the tags below the lead section? I think that location is probably what we wan to go with.

phuedx updated the task description. (Show Details)

@JKatzWMF: I can hard code the list but then I'll definitely have to stick it behind a feature flag.

Change 204490 had a related patch set uploaded (by Phuedx):
Beta: Add the Tags section

https://gerrit.wikimedia.org/r/204490

@KHammerstein i think we talked about putting this below the lead para

@JKatzWMF, @phuedx we can create a patch in Mediawiki-Config and populate the $wgMFBrowseTags variable with the list of tags. Sounds good?

Change 204490 merged by jenkins-bot:
Beta: Add the Tags section

https://gerrit.wikimedia.org/r/204490

@JKatzWMF, @KHammerstein: I'll create the necessary config change to show your sample tags on beta.

Change 206375 had a related patch set uploaded (by Phuedx):
Enable Browse experiment on labs

https://gerrit.wikimedia.org/r/206375

Hey @kaldari, @bmansurov: I don't think this is blocked on T96015. Even with the feature enabled, the "topic tags"/catagrokkies aren't clickable. Moreover, the config change only enables the feature on labs.

I'd like us to get this feature on labs as quickly as we can so it can be signed off as quickly as possible. Then, once the feature is complete enough we enabled it on enwiki.

Change 206375 merged by jenkins-bot:
Enable Browse experiment on labs

https://gerrit.wikimedia.org/r/206375

phuedx added a subscriber: KLans_WMF.

@KLans_WMF: I've moved this into the current sprint (Dan Garry) so that I don't forget to follow up with Design.

@phuedx Can we make "tags" the sans-serif font? Also we need more space after the tag, as much space as before the Tag title (24 px)